Fixbuild #1000
Open
Fixbuild #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kagahd, great contributions! I saw your recent PRs and pigallery2-metadata-editor, that's awesome. |
addianto
added a commit
to addianto/pigallery2
that referenced
this pull request
Jul 13, 2025
This merge commit imports the fixed CI build from [a pull request by kagahd](bpatrik#1000).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build failed due the deprecated
actions/upload-artifact@v3which this PR fixes by replacing it byactions/upload-artifact@v4.Moreover, to enable forked repositories to push the docker images to their own docker hub namespace, the namespace
bpatrikis replaced by${{ secrets.REGISTRY_NAMESPACE }}, so the users just need to add a github secret namedREGISTRY_NAMESPACEwith value of their docker hub namespace. It's not a secret per se but doing so aligns with the existing secretsREGISTRY_USERNAMEandREGISTRY_PASSWORD.I also added a
workflow_dispatchtrigger because it's handy to be able to run the workflow on demand and not just on commit.Last but not least I removed the
rm /var/cache/apk/*because first it may break the workflow if the github runner is still using the cache and secondly because it's not even needed since the option--no-cacheis used.