Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify search pad preselect #947

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Simplify search pad preselect #947

merged 4 commits into from
Nov 7, 2024

Commits on Nov 5, 2024

  1. chore(search-pad): use open marker for element pre-select styling 

    Turns out we don't need to build custom marker behavior
to have custom pre-select styling.

Once the search pad is opened there exist the djs-search-open marker
class on the diagram container that we can use for special styling.
    @nikku
    nikku committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    c70a7a8 View commit details
    Browse the repository at this point in the history

  2. test(search-pad): semantically group <open> tests

    @nikku
    nikku committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    010d127 View commit details
    Browse the repository at this point in the history

  3. fix(search-pad): clear selection when search opens 

    This ensures that all visual clutter is gone once the search pad
is opened. Of course, on <Escape> the search restores.
    @nikku
    nikku committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    5d8eb9a View commit details
    Browse the repository at this point in the history

  4. test(search-pad): verify open marker

    @nikku
    nikku committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f51211b View commit details
    Browse the repository at this point in the history