Skip to content

Conversation

barmac
Copy link
Member

@barmac barmac commented Jun 18, 2025

Proposed Changes

The PR removes interaction events registration and unregistration from the bendpoints module. This is already handled directly in the interaction events, and we do not want to unregister.

Try out via

npx @bpmn-io/sr bpmn-io/bpmn-js -l bpmn-io/diagram-js#965-remove-interaction-events-registration

Closes #965

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

This is already handled directly in the interaction events,
and we do not want to unregister.

Closes #965
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jun 18, 2025
@barmac barmac added backlog Queued in backlog and removed in progress Currently worked on labels Jun 18, 2025
@nikku
Copy link
Member

nikku commented Jun 18, 2025

For performance reasons we originally registered mouse move only when needed; but apparently today, we register it (and emit it) per default. So this feature, indeed, is legacy.

I could only spot a longer standing floating bendpoint glitch; otherwise this works "as expected":

capture IEcCyY_optimized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backlog Queued in backlog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bendpoints module introduces an "unexpected" side-effect

2 participants