Skip to content

feat: support zeebe:formDefinition #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

yT0n1
Copy link
Contributor

@yT0n1 yT0n1 commented Jun 18, 2025

Proposed Changes

Adds support for zeebe:formDefinition

related to camunda/camunda-modeler#5073

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jun 18, 2025
@yT0n1 yT0n1 requested a review from Copilot June 19, 2025 13:37
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for zeebe:formDefinition by updating the validation error messages and introducing new test cases for both valid and broken form definition templates.

  • Updated error message to include zeebe:formDefinition and zeebe:calledDecision as valid binding types.
  • Added tests for valid form definition templates.
  • Added tests for form definitions with binding errors.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
test/spec/validationSpec.js Updated the valid binding types error message to support new options.
test/fixtures/form-definition.json Added fixture for valid zeebe form definition templates.
test/fixtures/form-definition-broken.json Added fixture testing error scenarios for zeebe form definition.
Comments suppressed due to low confidence (2)

test/spec/validationSpec.js:255

  • Ensure that the updated error message is clearly documented and that related tests verify the presence of the new valid binding types.
          message: 'invalid property.binding type "zeebe:taskDefinition:foo"; must be any of { property, zeebe:taskDefinition:type, zeebe:input, zeebe:output, zeebe:property, zeebe:taskHeader, bpmn:Message#property, bpmn:Message#zeebe:subscription#property, zeebe:taskDefinition, zeebe:calledElement, zeebe:linkedResource, zeebe:userTask, zeebe:formDefinition, zeebe:calledDecision }'

test/fixtures/form-definition-broken.json:27

  • [nitpick] Consider extending the test assertions to check for a specific error message or error detail for bindings with an invalid property value to further ensure validation robustness.
        }

@yT0n1
Copy link
Contributor Author

yT0n1 commented Jun 26, 2025

merged with #56

@yT0n1 yT0n1 closed this Jun 26, 2025
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant