Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dialects #53

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Support dialects #53

merged 2 commits into from
Jun 4, 2024

Conversation

nikku
Copy link
Member

@nikku nikku commented Jun 4, 2024 •
edited
Loading

This allows you to pass a dialect to the feel-editor instance, i.e.

const editor = new FeelEditor({
  container,
  dialect: 'unaryTests' // defaults to 'expression'
});

capture JANICp_optimized

Child of bpmn-io/dmn-js#880

nikku added 2 commits June 4, 2024 15:52
@nikku
feat: allow to provide dialect
6fd26ce 
This enables me as a user to specify the FEEL dialect to use,
one of `expression` or `unaryTests`.
@nikku
test: improve editor linting spec
c17e4a4 
* get rid of internals (provide test utility)
* simplifies writing tests (and understanding them)
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jun 4, 2024
@nikku nikku requested review from a team, philippfromme and barmac and removed request for a team June 4, 2024 13:57
@nikku
Copy link
Member Author

nikku commented Jun 4, 2024

Includes test cleanup: c17e4a4.

nikku
nikku commented Jun 4, 2024
View reviewed changes
src/language/index.js
*
* @return {LanguageSupport}
*/
export function language(dialect) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barmac @marstamm I was not aware why we'd not use the built-in utilities to configure the language support (which already supports the two dialects).

Do you know? Doing manual testing I did not find anything broken.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My wild guess is that this part predates the support in the language. I wasn't involved in the development at the stage it was created though.

This was referenced Jun 4, 2024
Open
Draft
barmac
barmac approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff

@nikku nikku merged commit 026c0fa into main Jun 4, 2024
7 of 8 checks passed
@nikku nikku deleted the support-dialects branch June 4, 2024 22:03
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme philippfromme was automatically assigned from bpmn-io/modeling-dev

Assignees

@nikku nikku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikku @barmac