Rewrite #56
Merged
Rewrite #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* allow to bootstrap with position * configure language with provided context
In case where `baa|` is user input we only suggest `baawaap` and not `foo` as variables.
* group semantically * slight renames of specs * remove duplicate test
Fixes recovery on function positional arguments.
* You can now provide built-ins (other than Camunda)
as you instantiate the editor.
feat(autocompletion): filter completed built-ins
chore: simplify internal structure
* This is a larger rewrite of the inner structure of the tool,
fixing some longer standing bugs
chore: treat built-ins like special variables
fix: recognize built-ins in the language grammar
* We properly configure the language based on built-ins provided
this allows the grammar to recognize `get or else` or other
bogus built-ins that would otherwise be recognized as language
constructs
Related to camunda/camunda-modeler#3983
1 task
barmac
reviewed
Jun 17, 2024
marstamm
reviewed
Jun 17, 2024
src/autocompletion/variable.js
Outdated
Comment on lines
70
to
72
| if (!label.includes(match)) { | ||
| return -100; | ||
| } |
There was a problem hiding this comment.
As discussed in the walkthrough, this will remove fuzzy search from the suggestions. We can limit how many Items are shown by configuring maxRenderedOptions (default is 100), but I think ordering them is good enough.
This is done by @codemirror/autocomplete itself.
|
Ready for review (again). Please have a look! |
barmac
approved these changes
Jun 18, 2024
|
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR aims to improve the following:
You can try out the changes via
Related to camunda/camunda-modeler#3983
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}