Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds analytics tracking for user copy actions in the variable outline UI, leveraging the existing useTracking hook (bpmn-js-tracking integration).
Changes:
- Track variable name copy via the
CopyButton(variableNameCopy). - Track variable path/value copy via the JSON context menu (
variablePathCopy,variableValueCopy). - Add/adjust tests to validate new tracking behavior and update some shared test helpers.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/hooks/useContextMenuBehavior.js | Emits tracking events for context-menu “copy path/value” actions. |
| lib/components/CopyButton.jsx | Emits tracking event for “copy variable name” button clicks. |
| lib/hooks/test/useContextMenuBehavior.spec.jsx | New unit tests for context-menu copy tracking. |
| lib/components/test/CopyButton.spec.jsx | New unit test for copy button tracking. |
| lib/components/VariableRow/test/ValueDisplay.spec.jsx | Wraps ValueDisplay with InjectorContext in tests (to support tracking-enabled components). |
| lib/hooks/test/useVariables.spec.jsx | Test helper simplification (drops unused options parameter). |
| lib/context/test/FilterContext.spec.jsx | Test helper simplification (drops unused options parameter). |
| lib/components/Search/test/Search.spec.jsx | Test helper simplification (drops unused options parameter). |
| lib/components/ScopeList/test/ScopeList.spec.jsx | Removes unused injected args + test helper simplification. |
| CHANGELOG.md | Adds entry for the new tracking feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This pull request aims to introduce a tracking event for the copy action.
Checklist
Ensure you provide everything we need to review your contribution:
Closes {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}@bpmn-io/srtool