chore: reword search copy to reflect filter behavior#65
chore: reword search copy to reflect filter behavior#65
Conversation
|
@Balazs-PM what do you think about going ahead with this revision until we iterate towards enabling users to search among all the variables across the diagram? |
There was a problem hiding this comment.
Pull request overview
This PR updates the UI copy around the variables “search” input to accurately describe its current behavior as a filter over the displayed variable list (by variable name, origin, or scope), and records the change in the changelog.
Changes:
- Reword the search input placeholder and label to “Filter …” wording.
- Update the help tooltip text to describe filtering behavior.
- Adjust test descriptions and add a changelog entry for the copy change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/components/Search/Search.jsx | Updates placeholder/label and tooltip copy to reflect filtering semantics. |
| lib/components/Search/test/Search.spec.jsx | Renames test case descriptions to match “filter” terminology (behavior unchanged). |
| CHANGELOG.md | Adds an unreleased CHORE entry documenting the copy change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Do we want to embrace the filter feature, or rather move towards a full-fletched variable search? What is the vision for the variable outline? Given that the component is contextual, filter does make sense to me. |
I have been leaning onto the filtering functionality, but during recent sessions, the feedback was that search was expected to perform a global search in the diagram instead of a filtering functionality. Cf. internal comms For a global search, I think it goes beyond making the logic global rather than contextual as I find scopes overwhelming in case a global search for example. So, for now, I intend to reflect on the actual implementation of the input which is filtering. Until an agreed iteration, I'd like to go ahead with a clear copy at least. |
Proposed Changes
This pull request aims to reflect on the current behavior of the search bar which filters the shown variables rather than performing a search across the open diagram.
Cf. internal communication
Before
After
Checklist
Ensure you provide everything we need to review your contribution:
Closes {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}@bpmn-io/srtool