Skip to content

chore: reword search copy to reflect filter behavior#65

Open
barinali wants to merge 1 commit intomainfrom
reword-search-to-filter
Open

chore: reword search copy to reflect filter behavior#65
barinali wants to merge 1 commit intomainfrom
reword-search-to-filter

Conversation

@barinali
Copy link
Contributor

Proposed Changes

This pull request aims to reflect on the current behavior of the search bar which filters the shown variables rather than performing a search across the open diagram.

Cf. internal communication

Before

image

After

image

Checklist

Ensure you provide everything we need to review your contribution:

  • Contribution meets our definition of done
  • Pull request establishes context
    • Link to related issue(s), i.e. Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}
    • Brief textual description of the changes
    • Screenshots or short videos showing UI/UX changes
    • Steps to try out, i.e. using the @bpmn-io/sr tool

@barinali barinali self-assigned this Mar 23, 2026
@barinali barinali requested review from a team, Buckwich, Copilot and philippfromme March 23, 2026 15:20
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 23, 2026
@barinali
Copy link
Contributor Author

@Balazs-PM what do you think about going ahead with this revision until we iterate towards enabling users to search among all the variables across the diagram?

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the UI copy around the variables “search” input to accurately describe its current behavior as a filter over the displayed variable list (by variable name, origin, or scope), and records the change in the changelog.

Changes:

  • Reword the search input placeholder and label to “Filter …” wording.
  • Update the help tooltip text to describe filtering behavior.
  • Adjust test descriptions and add a changelog entry for the copy change.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
lib/components/Search/Search.jsx Updates placeholder/label and tooltip copy to reflect filtering semantics.
lib/components/Search/test/Search.spec.jsx Renames test case descriptions to match “filter” terminology (behavior unchanged).
CHANGELOG.md Adds an unreleased CHORE entry documenting the copy change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@barinali barinali requested a review from Balazs-PM March 23, 2026 15:22
@barmac
Copy link
Member

barmac commented Mar 23, 2026

Do we want to embrace the filter feature, or rather move towards a full-fletched variable search? What is the vision for the variable outline? Given that the component is contextual, filter does make sense to me.

@barinali
Copy link
Contributor Author

Do we want to embrace the filter feature, or rather move towards a full-fletched variable search? What is the vision for the variable outline? Given that the component is contextual, filter does make sense to me.

I have been leaning onto the filtering functionality, but during recent sessions, the feedback was that search was expected to perform a global search in the diagram instead of a filtering functionality. Cf. internal comms

For a global search, I think it goes beyond making the logic global rather than contextual as I find scopes overwhelming in case a global search for example. So, for now, I intend to reflect on the actual implementation of the input which is filtering. Until an agreed iteration, I'd like to go ahead with a clear copy at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review Review pending

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants