Syncing from upstream odoo/odoo (staging.saas-18.3) #34167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new module for Türkiye e-Dispatch. It generates an XML file for individual stock transfer which can be uploaded to Nilvera to create e-Deipatch records. TaskID:4270304 closes #217614 X-original-commit: 7285982 Signed-off-by: Wala Gauthier (gawa) <[email protected]> Signed-off-by: Manav Shah (sham) <[email protected]>
closes #216453 X-original-commit: 943b03f Signed-off-by: Florian Gilbert (flg) <[email protected]> Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <[email protected]>
__Issue:__ Condition used for MOs triggered under the `pbm_sam` manufacturing flow only checks the start of the group name, not the whole name, which could fail in case triggered by reordering rules where the origin might be a compound string such as: "OP/00001,WH/MO/00001" __Steps to reproduce:__ 1.) Install sales; inventory; manufacturing 2.) Enable multi-step routes 3.) Unarchive MTO 4.) Set warehouse manufacture steps to: Pick components, manufacture, then store products (3 steps) (manufacture_steps == 'pbm_sam') 5.) Create product A-bom (enable manufacture and mto routes) 6.) Create product B (enable manufacture) 7.) Add Product A as bom for product B 8.) Add a reordering rule (manufacture) for product B 9.) run SA Procurement: run scheduler Error: duplicate key value violates unique constraint opw-4866263 bug found: [#c50cb9d][1] [1] : c50cb9d closes #217617 X-original-commit: c604235 Signed-off-by: William Henrotin (whe) <[email protected]> Signed-off-by: Verina Gad (vega) <[email protected]>
For reasons explained in [1], waitFor should be used for popovers in order to avoid non-deterministic failures on runbot. [1]: 54da715 X-original-commit: 6d9127d Part-of: #217605 Signed-off-by: David Monjoie (dmo) <[email protected]>
It had so much awaits in the same test itself that it could reach the timeout of the test when the runbot was slow enough, leading to non-deterministic failures. Splitting them solves the issue and there was no real reason to execute all these in a single test case. closes #215168 closes #217605 X-original-commit: 2e6dd68 Signed-off-by: David Monjoie (dmo) <[email protected]>
In this commit, we fix the donation_snippet_use tour. At the end of the tour, when you click on submit donation, you are redirected to a page "Your payment has been processed." From this page, you are then redirected to a page with "Thank you". This intermediate redirection page can be a problem if there are several steps that concern it because we do not know when the redirection will be triggered (in the first or the second step?) Therefore, it is essential to have only one step for intermediate redirections. closes #217448 X-original-commit: b6073e5 Signed-off-by: Bastien Fafchamps (bafa) <[email protected]> Signed-off-by: Pierre Pulinckx (pipu) <[email protected]>
…ies button This issue has happened because of the standard change in the module. traceback when editing the toggle button, through the website editor The element '<xpath expr="//del">' cannot be located in the parent view Current behavior before PR the module website_event_sale and website_sale_loyalty inherits the cart_line The Targeted node is available in the view But in version 18.3, the targeted node has its own template That's why the XPath is broken. I targeted the new template for resolving the issue. I changed the inheritance of the view Issued PR-190720 OPW-4864959 closes #215180 Signed-off-by: Antoine Vandevenne (anv) <[email protected]>
Since [1], discuss considers both the logged in and the portal partner as "self". However, even if the token grants access to act as the portal partner, it doesn't mean that both users are the same. Visually, it's confusing that every hint in the UI assimilate the current user to the portal partner (messages, mentions, ...). This commit partially reverts [1]: portal partner is not returned when the user is logged in. [1]: #211204 task-4915478 closes #217522 X-original-commit: 9e3ac2e Signed-off-by: Matthieu Stockbauer (tsm) <[email protected]>
Step to reproduce - Go to Project - Go to Reporting > Task Analysis - Group by Tasks (not Task) - Click on any of the blue bars Issue: since c36ad1896 we now allow user to drill down to base model from report view, this causes issue when a field which is present in report model but not in base/main model. For now we directly pass the domain created for report view to base model. Fix: we remove such fields from domain and then load the view opw-4798353 closes #217461 X-original-commit: 216ccf4 Related: odoo/enterprise#89483 Signed-off-by: Xavier Bol (xbo) <[email protected]>
This commit adds the the unit e.g. 'kg' to each orderline next to the quantity. The reason for this change was to satisfy the requirements of the LNE to allow Odoo to be certified for weighing scales in the EU. task-4869128 closes #216059 X-original-commit: c9b9376 Related: odoo/enterprise#88622 Signed-off-by: Yaroslav Soroko (yaso) <[email protected]> Signed-off-by: Max Whale (mawh) <[email protected]>
… common name to be unique per journal Previously, the company name was used as the common name when onboarding the journal. However, the common name has to be unique. The fix changes the common name to use the journal's short code, journal name, and company name to ensure uniquness. Additionally, an improvement is applied to the serial number on journals. Previously, users inputted this field manually. Now, the system uses the journal's id as the serial number to ensure uniqueness. A post-migration script was added to notify users that they need to re-onboard their journals. This is done in case users previously onboarded journals with non-unique serial numbers. task-4797124 closes #217631 X-original-commit: c4f492c Signed-off-by: Josse Colpaert (jco) <[email protected]> Signed-off-by: Khaled Fahmy (khfa) <[email protected]>
Issue: When having two lines on an invoice with the same tax and different analytic distribution, the base value is doubled on the tax report. Steps to reproduce: - Create a new taxe on sales (eg 10%) - Make sure the option "Analytic Accounting" is ticked in the settings - Create an invoice with two lines (eg both at $100), add the tax on both - Change the analytic distribution on both lines to different values - Confirm the invoice - Go to the tax report - Select the report "Group By: Account > Tax" - On the report the "Net" amount is doubled ($400), the tax amount is correct ($20) Cause: On the invoice we can see in "Journal Items" that two tax lines are created instead of one (one for each analytic distribution). The "Group By" reports are generated by [this query](https://github.com/odoo/odoo/blob/51fcbd211d2b1abf4b93becedbcbb9e03002cdd6/addons/account/models/account_move_line_tax_details.py#L92). At the [creation of the second subtable](https://github.com/odoo/odoo/blob/51fcbd211d2b1abf4b93becedbcbb9e03002cdd6/addons/account/models/account_move_line_tax_details.py#L164-L198) the move lines are linked together based among other things on the tax id. The [filter on analytic distribution](https://github.com/odoo/odoo/blob/51fcbd211d2b1abf4b93becedbcbb9e03002cdd6/addons/account/models/account_move_line_tax_details.py#L187-L191) does not apply here as `tax.analytic = False`. The result is that each tax line is linked with both base lines. The second subtable have 4 lines in this case, with each base line doubled. The result of the query have the base amount doubled. Solution: We cannot fix the query as there is no link to find the tax line origin amongst the base lines. The method `_read_generic_tax_report_amounts` in `account_reports` is made to fix the base values in report in case of duplicate. Until now it did not include the duplication caused by analytic distribution but duplication because of repartition lines for example. The fix is to use this method also for analytic distribution. So we add `tdr.analytic_distribution` in the `GROUP BY`. This value must be returned by the query in `account` so we add it. opw-4753676 closes #217569 X-original-commit: 27babd4 Related: odoo/enterprise#89569 Signed-off-by: Laurent Smet (las) <[email protected]> Signed-off-by: Mathieu Coutant (mcou) <[email protected]>
After [this PR](#209628) was merged, a few last comments were made, this commit includes the changes suggested in those comments. task-none closes #216815 Signed-off-by: William André (wan) <[email protected]>
Steps to reproduce: ---- - Install portal module - Grant a portal access to a contact - Go to the email template (Portal: User Invite) for the contact - Click on Preview -> Traceback Issue: --- The display was based on the user itself referencing to a partner. And there was no name for the portal users. Fix: --- Changed the view so now the different values are based on the partner.Also added the name to this function based on the partner name. opw-4444729 closes #211548 X-original-commit: 2cee2b4 Signed-off-by: Andrzej Pietrusiak (pian) <[email protected]>
Before this commit, the `get_current()` method in the wifi helper would occasionally run very slowly, taking 5-15 seconds. This is because the `nmcli` command it was calling would periodically re-scan the network so the information it returned was up-to-date. Because the homepage data controller used this method, it would also sometimes take 5-15 seconds to load, leading to a bad experience for the user. After this commit, the `get_current()` method uses a different `nmcli` command that only shows the status of the currently connected network, avoiding a re-scan and therefore always running quickly. task-4922640 closes #217682 Signed-off-by: Louis Travaux (lotr) <[email protected]>
Scenario: - insert the last blog posts widget in a page using Card Layout - open editor and edit (eg. Background) the cover of a post - save Result: the change is lost Cause: the content of the widget is dynamic, and we delete the content in cleanForSave (that call the destroy of the widget) before saving, so the change are not saved. Fix: make the dynamically added cover widget unselectable, the cover of the blog post can still be changed in other locations (blog post list, blog post page). Note: the issue doesn't happen in 17.0 in big picture template, because the figcaption is not a children of the cover snippet. It happens in 18.0 because the content of the cover is a children of the cover. opw-4633287 closes #214905 X-original-commit: e5ba9ac Signed-off-by: Quentin Smetz (qsm) <[email protected]> Signed-off-by: Nicolas Lempereur (nle) <[email protected]>
This commit: e2a0c6e change a help in the intercompany rules. The help sentence is wrong since we don't create invoice but bills. task-4907810 closes #217275 Related: odoo/enterprise#89368 Signed-off-by: William André (wan) <[email protected]>
The dict contained 2 different examples for a tax number in Japan. Keeping the one that is matching the company registry example, but positionning it correctly in the dict. closes #217710 Signed-off-by: Josse Colpaert (jco) <[email protected]>
An error occurs if the Validity Period is removed while creating a new allocation. Steps to reproduce: - Install the 'hr_holidays' module - Time Off > My Time > My Allocation - Open New and remove the 'Validity Period' Traceback: AttributeError: 'bool' object has no attribute 'strftime' This commit ensures that changing the date won't cause an error, but instead will display a warning upon saving the form, as it is a required field. sentry-6709097746 closes #216015 Signed-off-by: Bertrand Dossogne (bedo) <[email protected]>
Before this commit, several invisible fields were present in the views, whereas after #162009 these fields need to be either justified or removed. The needed fields are fetched automatically after #137031 This commit adds a comment to each field so that the tests pass in stable versions, to avoid potential issues with inheritance in custom views. We will remove the unnecessary invisible fields in master. closes #216095 X-original-commit: bf9d7b0 Related: odoo/enterprise#88643 Signed-off-by: William André (wan) <[email protected]>
Now that the frontend is showing the device connection type, we can remove this prefix since it is showing duplicate information. task-4922608 closes #217770 Related: odoo/enterprise#89664 Signed-off-by: Louis Travaux (lotr) <[email protected]>
Steps to reproduce: - Navigate to a Project > View (Timesheets) - Open studio and add x_plan2_id for example to the view - Try creating a new timesheet and set a value for the field we added using studio - Save and notice the field doesn't keep its value Cause: This is mainly happening because when getting the plan_ids for the account we are gonna fill we just get the account in the distribution and ignore if the user is setting another value Fix: We check the create vals_list if a plan has value we set it before setting the account in the distribution opw-4716041 closes #217715 X-original-commit: 879e721 Signed-off-by: Xavier Bol (xbo) <[email protected]> Signed-off-by: Youssef Bashandy (yoba) <[email protected]>
On mobile, opening the message actions requires precise tapping, as the user has to touch a very small icon. This PR replaces that with a long press, a more intuitive and classical way to access these actions. Related: odoo/enterprise#89402 Related: odoo/enterprise#89584 Part-of: #217626 Signed-off-by: Alexandre Kühn (aku) <[email protected]>
On mobile, the message action menu is a modal, as are the view/add reactions panels. Modals add a dark background overlay to the page. In this case, the background becomes darker when accessing a submenu and lighter when returning from it. This change in background intensity feels a bit odd. This commit ensures that there is at most one modal background. Related: odoo/enterprise#89402 Related: odoo/enterprise#89584 Part-of: #217626 Signed-off-by: Alexandre Kühn (aku) <[email protected]>
The message reaction menu shows who reacted to a message. Currently, it opens as a modal in the middle of the screen, unlike other modals which appear at the bottom (e.g., add reaction). This also hides the active message highlight. Additionally, the menu closes immediately when clicking away, unlike other submenus, making navigation harder. This commit moves the reaction menu to the bottom like add reaction, tweaks its style for clarity on mobile, and changes click-away to return to the main menu—improving mobile usability. Related: odoo/enterprise#89402 Related: odoo/enterprise#89584 Part-of: #217626 Signed-off-by: Alexandre Kühn (aku) <[email protected]>
Now that longpress is used to open the message actions menu, it's not possible to select text inside a message anymore. This commit adds a "copy" option that allows to copy the message text.tmp Related: odoo/enterprise#89402 Related: odoo/enterprise#89584 Part-of: #217626 Signed-off-by: Alexandre Kühn (aku) <[email protected]>
Looks best with discuss style that uses rounded shapes. closes #217310 closes #217626 Related: odoo/enterprise#89402 Related: odoo/enterprise#89584 Signed-off-by: Alexandre Kühn (aku) <[email protected]>
When creating a sale order through crm, default_user_id was being passed through the context. This was causing issues when confirming the sale orders when quality checks were enabled as the user on the quality checks would be set as the user from the CRM lead. Removing this from the context before confirming and thus creating any linked records avoids this issue. opw-4658850 closes #216953 X-original-commit: 1540c30 Signed-off-by: Ryan Cen (ryce) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bt_gitbot