Syncing from upstream odoo/odoo (tmp.16.0) #34176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the original session id that initialised the http request. task-4922056
closes #217341 Signed-off-by: Ruben Gomes (rugo) <[email protected]>
Currently, a user needs to be time off, expense and timesheet approver of an employee for those links to be removed by the departure wizard. If not all the approver fields are the same user, that link will not be removed. Steps to reproduce: - Set Marc Demo as only Time Off approver on an employee. - Archive Marc Demo's employee (This does not remove time off approver from the previous employee) To rectify this issue, we correctly group the `user_domain` so that their contents are properly OR'd. closes #213513 Signed-off-by: Bertrand Dossogne (bedo) <[email protected]>
Versions -------- - 16.0+ Steps ----- 1. Have a fiscal position with a country-based tax mapping; 2. go to `/shop` as a public user, 3. create a new account; 4. add a product to your cart; 5. go to user settings & add an address that matches the fiscal position; 6. go to checkout & pay for the cart. Issue ----- The fiscal position's taxes aren't applied to the order. Cause ----- The `_compute_fiscal_position_id` method is triggered when changing the `partner_id` or `partner_shipping_id` of an order. It does not trigger when modifying the address of the order's current partner. There is logic in place to recompute fiscal position & taxes when an address gets entered via checkout, but not via any other route. Solution -------- Adding address fields to the `api.depends` of the compute method could introduce the unintended behavior of changing taxes & fiscal position of confirmed sale orders. Instead, we can check for fields relevant to fiscal position in `write`, then search for unconfirmed website orders, and recompute their fiscal position & taxes if need be. opw-4844132 closes #214588 Signed-off-by: Levi Siuzdak <[email protected]>
Steps to Reproduce: - Set the Odoo backend language to Spanish. - Enter edit mode. - Drag and drop the "Text-Image" snippet. - Click on the image within the dropped snippet. Bug: The "Layout" menu in the sidebar overflows, causing a horizontal scrollbar. Issue: The width of the `we-button` elements within the `we-button-group` was not handled correctly. In the Spanish translation, the text in the "Layout" options was too long, resulting in overflow and a horizontal scrollbar in the sidebar. Solution: This commit addresses the layout issue specifically for DOM structure involving `we-button-group` and `we-select`. Without affecting other styles, it applies a grid template to equally divide the available space among the buttons, preventing overflow. task-4378522 closes #189856 Signed-off-by: Benjamin Vray (bvr) <[email protected]>
Issue:
Printing the BOM crashes when one of the byproduct quantity is set to 0
Steps to reproduce:
- Open the manufactoring app
- Go to settings and activate by-product settings
- Go to Products > Bills of Materials
- Open a BOM
- Put the quantity of one the by-product by 0
- Click on overview
- Click on the print button
Cause:
In the `mrp_report_bom_structure.xml` template, there is this division:
- `<td class="text-end" t-esc="byproduct['bom_cost'] / byproduct['quantity']" t-options='{"widget": "monetary", "display_currency": currency}'/>`
without checking if `byproduct['quantity']` is different than 0.
Solution:
Added the check on `byproduct['quantity']` in the foreach
Additional notes:
Since it makes no real sense to have a non-zero BoM cost associated with a byproduct whose quantity is zero, the cost is set to 0 when the quantity is 0.
opw-4853525
closes #213936
Signed-off-by: Tiffany Chang (tic) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bt_gitbot