Syncing from upstream odoo/odoo (tmp.saas-18.4) #34194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the `channel _to_store_defaults` query count to the correct value. This increase is related to #216031. closes #217676 Signed-off-by: Sébastien Theys (seb) <[email protected]>
*: survey, website, website_blog, website_event, website_forum. Updates imports to use the new html_builder scrollTo method instead of the deprecated web_editor. Part of the [html_builder refactoring] [html_builder refactoring]: 9fe45e2b7ddb Related to task-4367641 closes #217482 Signed-off-by: Francois Georis (fge) <[email protected]>
This commit fixes the `test_chatbot_steps_sequence_ui` and the `test_chatbot_steps_sequence_with_move_ui` tours. Those tours create chat bot steps to check their order. To do so, they edit the textarea and click on the save button. However, under high load, the button can be clicked before the textarea is updated. When this occurs, the validation fails and the step is not created. This commit fixes the issue by waiting for the textarea content to update before clicking on the save button. fixes runbot-228498 closes #217760 Signed-off-by: Alexandre Kühn (aku) <[email protected]>
Comments applied from the previous PR. 1. Reduce duplicate code in im_livechat; 2. Remove unused code in im_livechat; follow up of #217584 closes #217738 Related: odoo/enterprise#89648 Signed-off-by: Alexandre Kühn (aku) <[email protected]>
closes #217787 X-original-commit: 027d07d Signed-off-by: Ruben Gomes (rugo) <[email protected]> Signed-off-by: Josse Colpaert (jco) <[email protected]>
When creating a sale order through crm, default_user_id was being passed through the context. This was causing issues when confirming the sale orders when quality checks were enabled as the user on the quality checks would be set as the user from the CRM lead. Removing this from the context before confirming and thus creating any linked records avoids this issue. opw-4658850 closes #216982 X-original-commit: 1540c30 Signed-off-by: Ryan Cen (ryce) <[email protected]>
This commit adds a new module for Türkiye e-Dispatch. It generates an XML file for individual stock transfer which can be uploaded to Nilvera to create e-Deipatch records. TaskID:4270304 closes #217661 X-original-commit: 074a117 Signed-off-by: Wala Gauthier (gawa) <[email protected]> Signed-off-by: Manav Shah (sham) <[email protected]>
An error occurs if the Validity Period is removed while creating a new allocation. Steps to reproduce: - Install the 'hr_holidays' module - Time Off > My Time > My Allocation - Open New and remove the 'Validity Period' Traceback: AttributeError: 'bool' object has no attribute 'strftime' This commit ensures that changing the date won't cause an error, but instead will display a warning upon saving the form, as it is a required field. sentry-6709097746 closes #217823 X-original-commit: 70d7842 Signed-off-by: Bertrand Dossogne (bedo) <[email protected]> Signed-off-by: Aayush Modi (aamo) <[email protected]>
…ies button This issue has happened because of the standard change in the module. traceback when editing the toggle button, through the website editor The element '<xpath expr="//del">' cannot be located in the parent view Current behavior before PR the module website_event_sale and website_sale_loyalty inherits the cart_line The Targeted node is available in the view But in version 18.3, the targeted node has its own template That's why the XPath is broken. I targeted the new template for resolving the issue. I changed the inheritance of the view Issued PR-190720 OPW-4864959 closes #217718 X-original-commit: c1434fc Signed-off-by: Antoine Vandevenne (anv) <[email protected]>
After [this PR](#209628) was merged, a few last comments were made, this commit includes the changes suggested in those comments. task-none closes #217790 X-original-commit: c0b8691 Signed-off-by: William André (wan) <[email protected]> Signed-off-by: Thomas Becquevort (thbe) <[email protected]>
In this commit, we fix the donation_snippet_use tour. At the end of the tour, when you click on submit donation, you are redirected to a page "Your payment has been processed." From this page, you are then redirected to a page with "Thank you". This intermediate redirection page can be a problem if there are several steps that concern it because we do not know when the redirection will be triggered (in the first or the second step?) Therefore, it is essential to have only one step for intermediate redirections. closes #217717 X-original-commit: d68db06 Signed-off-by: Bastien Fafchamps (bafa) <[email protected]> Signed-off-by: Pierre Pulinckx (pipu) <[email protected]>
**Problem:** When refunding an order that has been paid using a reward system, the points are deducted again as if the client made another purchase using those points. This means that in the case of a refund, the client would not only lose those points but have to spend them again. **Steps to reproduce:** - Make a purchase in POS using a reward such as $1 for every point - Refund this purchase - The points are deducted again **Why the fix:** The points do not need to be refunded after a refund, but they don't have to be paid again. The total point for this refund order is now set to zero in case of a refund. This means the transaction will not be visible on the Coupon Card in the Loyalty Program. opw-4771724 closes #217390 X-original-commit: 368bc34 Signed-off-by: David Monnom (moda) <[email protected]> Signed-off-by: Arthur Nanson (artn) <[email protected]>
Before this commit, the `get_current()` method in the wifi helper would occasionally run very slowly, taking 5-15 seconds. This is because the `nmcli` command it was calling would periodically re-scan the network so the information it returned was up-to-date. Because the homepage data controller used this method, it would also sometimes take 5-15 seconds to load, leading to a bad experience for the user. After this commit, the `get_current()` method uses a different `nmcli` command that only shows the status of the currently connected network, avoiding a re-scan and therefore always running quickly. task-4922640 closes #217792 X-original-commit: 8bfb927 Signed-off-by: Louis Travaux (lotr) <[email protected]> Signed-off-by: Max Whale (mawh) <[email protected]>
Waiting an animationFrame after each click (fix done in [1]) was not sufficient, we actually need to wait for 2 or 3 separate ticks depending on the case, because `customizeWebsiteColors` calls between 2 and 3 debounced functions (`debouncedSCSSColorsCusto`, possibly `debouncedSCSSVariablesCusto`, and finally `reloadBundles`) with a 0-ms delay. [1]: cbcd1b1 runbot-229604 runbot-229686 closes #217647 Signed-off-by: Francois Georis (fge) <[email protected]>
The upgrade script from saas-18.3 to saas-18.4 converting the default value of text filter is wrong. It didn't account for the empty string which should be considered as "no default value" `defaultValue: "hello"` --> `defaultValue: ["hello"]` correct `defaultValue: ""` --> `defaultValue: [""]` not correct closes #217873 Task: 4926326 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
Steps to reproduce: 1. Connect IoT Box and any printer that accepts PDF 2. Turn on Reception Report option on Inventory Settings 3. Set configuration of Receipts to print out Reception Report and Label 4. Assign Reception Report and label to the printer 5. Create a PO and run through the Reception process (PO > Reception of Delivery) 6. Print the Reception Report under "Allocations" -> Result: Reception Report and label is downloaded as a PDF instead of being sent to the printer. The reason for this bug is that the report models were being constructed directly in the frontend, rather than being fetched from the backend. This didn't work with IoT printing because its override used to assign devices to reports is on the backend `ir.actions.report` model. The fix is to fetch the report from the backend when the component is loaded. This report is then passed down to the child components as well. opw-4790299 closes #217828 X-original-commit: fb78c5a Related: odoo/enterprise#89705 Signed-off-by: Louis Travaux (lotr) <[email protected]> Signed-off-by: Max Whale (mawh) <[email protected]>
Now that the frontend is showing the device connection type, we can remove this prefix since it is showing duplicate information. task-4922608 closes #217825 X-original-commit: 6f804db Related: odoo/enterprise#89703 Signed-off-by: Louis Travaux (lotr) <[email protected]> Signed-off-by: Max Whale (mawh) <[email protected]>
This commit: e2a0c6e change a help in the intercompany rules. The help sentence is wrong since we don't create invoice but bills. task-4907810 closes #217793 X-original-commit: c7f11ff Related: odoo/enterprise#89683 Signed-off-by: William André (wan) <[email protected]> Signed-off-by: Maximilien La Barre (malb) <[email protected]>
**Problem:** When cashier A is assigned to an order, then changed during the payment screen process to cashier B, the receipt will display Served by cashier A. It should be Served by cashier B as this is the one that closed the order. This used to work until 18.0. **Steps to reproduce:** - Add some employees to your PoS, using pos_hr - Select one of them, then change to another one during the payment screen, before paying - Pay for it, the receipt screen still displays the first cashier **Why the fix:** The receipt should first display the current cashier, not the order's cashier. It was done the other way around before this commit. We now first display the session's cashier, then if not available we display the order's cashier. opw-4868038 closes #217480 X-original-commit: 1abbce3 Signed-off-by: Adrien Guilliams (adgu) <[email protected]> Signed-off-by: Arthur Nanson (artn) <[email protected]>
closes #214016 Signed-off-by: Francois Georis (fge) <[email protected]>
Change label of `non_deductible_account_id` field on `account.journal` from `Private Part Account` to `Private Share Account` as private part means something else in english. task-4868244 closes #217852 X-original-commit: f665307 Signed-off-by: William André (wan) <[email protected]> Signed-off-by: Pratham Nareshbhai Patel (ppat) <[email protected]>
Issue: Copying a bom with an operation will not reassign the copied operation to the by product lines. Steps to reproduce: - In the settings enable operations and by-products - Create a bom with an operation op1 and a by product produced in op1 - Copy the bom > The copied by product line refer to the operation of the original bom > this can be checked by archiving the copied operation which should > erase its link with the copied by product line but will not Cause of the issue: When a bom is copied, the new operation is reassigned to the new bom lines by these lines: https://github.com/odoo/odoo/blob/9cb4230a6b2252243a8e0546a1a8f5bc52e74009/addons/mrp/models/mrp_bom.py#L230-L247 However, nothing is made for the by product lines. opw-4788252 closes #217842 X-original-commit: 75668dd Signed-off-by: William Henrotin (whe) <[email protected]> Signed-off-by: Lancelot Semal (lase) <[email protected]>
Steps to reproduce: - Open website builder in translate mode - Insert literally "<br>" in the text - Save - Bug: text "<br>" has been replaced by "<br>" Commit that re-introduced the escape of text nodes: 2bee90e task-4367641 Part-of: #217367 Signed-off-by: Sébastien Blondiau (blse) <[email protected]>
Steps to reproduce: - Open website builder on `/blog` - Insert literally "<br>" in the text in the title of a blog post - Save - Bug: text "<br>" has been replaced by "<br>" Commit that re-introduced the escape of text nodes: 2bee90e task-4367641 Part-of: #217367 Signed-off-by: Sébastien Blondiau (blse) <[email protected]>
Steps to reproduce: - Open website builder - Drop a section - Insert literally "<br>" in its text - Click on "Save this block to use it elsewhere" - Use the block - Bug: text "<br>" has been replaced by html "<br>" NOTE: the same issue exists on stable since at least 16.0. It was fixed by 2bee90e, but this commit added the escaping of text nodes in too many situations task-4367641 closes #217367 Signed-off-by: Sébastien Blondiau (blse) <[email protected]>
At the moment, the `assertXmlTreeEqual` test method doesn't check that the namespaces in the generated XML match the ones in the expected XML. This is a 'feature', but in practice it prevents us from ensuring that our generated XMLs are correct. We remove this behaviour: from now on, we also check namespace equality. task-none closes #217426 X-original-commit: 16ec094 Related: odoo/enterprise#89476 Signed-off-by: Laurent Smet (las) <[email protected]> Signed-off-by: Antoine Dupuis (andu) <[email protected]>
Since `html_builder` was merged, font family selection is not implicitly quoted anymore. This is a problem for font families having names that contain spaces. This commit puts font family names between quotes before calling `customizeWebsiteVariable`. Steps to reproduce: - Go to the Theme tab - Pick "Open Sans" as font family - Inspect page => The used font was not "Open Sans". task-4367641 closes #217753 Signed-off-by: Francois Georis (fge) <[email protected]>
When an image is added from a CORS URL, the image data cannot be obtained from the web browser. Because of this, converting the image to another format, adjusting its quality or other manipulations are not possible. Currently the "Quality" option appears for CORS image - but disappear when trying to use it, which also corrupts the image. This commit hides the "Quality" option when converting to another format is anyway unavailable. Steps to reproduce: - drop an image block - replace an image by using "Add URL" and specify a [non-CORS image] - "Quality" option was available and could be used - replace an image by using "Add URL" and specify a [CORS image] => "Quality" option was available, but should not have been. Upon use, image was lost and "Quality" option disappeared. [non-CORS image]: https://upload.wikimedia.org/wikipedia/commons/thumb/2/2f/Thysanoptera.jpg/420px-Thysanoptera.jpg [CORS image]: https://tinyjpg.com/images/social/website.jpg task-4367641 closes #217302 Signed-off-by: Francois Georis (fge) <[email protected]>
This commit adapts the `GenerateDialog` component for generating serial numbers, for the change introduced in #205486, which changes the value of m2o to be an object instead of an array. Previous to this commit, an error was thrown when the dialog is opened for a lot-tracked product because the template tries to access `move.product_uom[1]`. closes #217714 Signed-off-by: Quentin Wolfs (quwo) <[email protected]>
…rt layout Steps to Reproduce: 1. Go to Settings > Companies > Configure Document Layout. 2. Choose layout Boxed or any layout that horizontally places the company logo and address. 3. Edit the address block choose long string. 4. Save the layout and click Preview Document or print SO or invoice. Issue: Observe in PDF output the long text overlaps into logo or extend outside the layout bound(differ in layouts) — even though enough space is visually available Cause: A previous change in PR #201198 added the text-nowrap class to address blocks to fix a minor wrapping issue. However, this unintentionally caused layout overflow issues with long lines. Solution: - Added width to the address block to ensure balanced layout structure. - Removed text-nowrap from all layouts, as the original issue is now resolved by applying proper width sizing. - Removed float-end from Boxed layout, as it was contributing to misalignment. Additional Notes: All behaviors addressed by PR #201198 were re-tested to ensure this fix does not reintroduce previous issues. opw-4764975 closes #217841 X-original-commit: 0a45a1e Signed-off-by: Bastien Fafchamps (bafa) <[email protected]> Signed-off-by: Khushi Srivastava (khsr) <[email protected]>
The dict contained 2 different examples for a tax number in Japan. Keeping the one that is matching the company registry example, but positionning it correctly in the dict. closes #217794 X-original-commit: af607be Signed-off-by: Josse Colpaert (jco) <[email protected]> Signed-off-by: William André (wan) <[email protected]>
This fixes some rendering issues with the payroll tab. closes #216240 Task: 4885749 Related: odoo/enterprise#88734 Signed-off-by: Yannick Tivisse (yti) <[email protected]>
Cash rounding lines (`display_type == 'rounding'`) were excluded from the total document amount (`importo_totale_documento`) in the electronic invoice XML, leading to discrepancies between invoice totals and XML output. This fix adds rounding line totals to `importo_totale_documento` to comply with Italian fiscal requirements (Art. 13, D.Lgs. 231/2007) and ensures XML accuracy. Task-4816355 closes #214671 X-original-commit: 581e04c Signed-off-by: Paolo Gatti (pgi) <[email protected]> Signed-off-by: Ahmed Elemary (aele) <[email protected]>
Currently, an error occurs when opening the product in the shop. Steps to Reproduce: - Install the website_sale module. - Go to Products, open any product, navigate to the Sales tab, and add at least one tag. - Go to Website > Shop, and open the same product. AttributeError: 'product.tag' object has no attribute 'visible_on_ecommerce' This error occurs when opening a product in the shop. In this commit 6d0d8d9, it was mentioned that the field visible_on_ecommerce has been renamed to visible_to_customers. The error started occurring after this commit eac892a, where the visible_on_ecommerce attribute is used as a tag attribute [1], which causes the error. [1] https://github.com/odoo/odoo/blob/850e575b71b04597d31140cec53a596456370325/addons/website_sale/views/templates.xml#L2333 This commit ensures that visible_to_customers is used in place of visible_on_ecommerce. sentry-6731935669 closes #217871 Signed-off-by: Antoine Vandevenne (anv) <[email protected]>
**Steps to reproduce:**
- Install Accounting + Inventory + Sales apps
- Enable Automatic Accounting in Settings
- Ensure two companies are available
- Set one product category (same for both companies)
- For company 1 (current) -> FIFO + automatic valuation (`'real_time'`)
- For company 2 -> FIFO + manual valuation (`'manual_periodic'`)
- Create a storable product for this category
- From company 1:
- Buy 10 products at 10$ each and receive them (Purchase + Delivery)
- Sell 15 products at 10$ each and deliver them (Sale + Delivery)
- Buy 10 products at 10$ (Purchase)
- Switch to company 2 (keep company 1 checked)
- From company 2:
- Validate the third delivery order (WH/IN)
- Go to Inventory/Reporting/Valuation
- One journal entry is missing for the last move
**Issue:**
During the processing of the SVL in `_run_fifo_vacuum`, the product used its current env context company
instead of the one provided explicitly in the parameters. This caused inconsistencies in valuation logic
when the method used differed between the given companies, which results in a missing `account_move_id`.
**Fix:**
Ensure that the product is evaluated in the correct company context by using
`self.with_company(company.id)` when looping on the products before the valuation logic.
opw-4732067
closes #217059
X-original-commit: 6731163
Signed-off-by: Steve Van Essche <[email protected]>
Signed-off-by: Florentin Delcourt (defl) <[email protected]>
When adding `html_builder`, some new data attributes were added on images. Those new attributes were not made safe, and might therefore be lost during HTML sanitization. This commit adds the new data attributes to the while list. Steps to reproduce: - Install `website_forum`. - Login as administrator. - Go to "Forum" then "About this forum". - Edit, add an image inside the FAQ and save. - If you inspect the image, it has `data-attachment-id` and `data-format-mimetype` attributes. - Go to Setting. - Setup a "Restricted Editor" user. - In debug mode, go to "Access Rights". - Add write access to `forum.forum` model for "Role / Member" users. - Logout. - Login as the "Restricted Editor" user. - Go to the forum's FAQ page. - Edit, change the text, save. => The attributes `data-attachment-id` and `data-format-mimetype` were lost. task-4367641 closes #217903 Signed-off-by: Francois Georis (fge) <[email protected]>
Misc data modifications and corrections for l10n_be. * Updated the CoA (accounts, descriptions, translations) * Added taxes on some accounts, notably 21%D35 and 21%IG ND * Create asset models and add them on related accounts * Renamed fields to be more correct See task-4791757 for more details. Related : odoo/enterprise#87067 closes #217414 X-original-commit: 4395455 Related: odoo/enterprise#89471 Signed-off-by: Ruben Gomes (rugo) <[email protected]> Signed-off-by: William André (wan) <[email protected]>
The test in this module imports a common setup from account_reports which is not a dependency, and is not auto installed when the test runs with comunity modules only. This fix replaces the setup by the community one AccountTestInvoicingCommon. closes #217829 X-original-commit: 591acd3 Signed-off-by: Jinane Maksoud (maji) <[email protected]>
Issue: When having two lines on an invoice with the same tax and different analytic distribution, the base value is doubled on the tax report. Steps to reproduce: - Create a new taxe on sales (eg 10%) - Make sure the option "Analytic Accounting" is ticked in the settings - Create an invoice with two lines (eg both at $100), add the tax on both - Change the analytic distribution on both lines to different values - Confirm the invoice - Go to the tax report - Select the report "Group By: Account > Tax" - On the report the "Net" amount is doubled ($400), the tax amount is correct ($20) Cause: On the invoice we can see in "Journal Items" that two tax lines are created instead of one (one for each analytic distribution). The "Group By" reports are generated by [this query](https://github.com/odoo/odoo/blob/51fcbd211d2b1abf4b93becedbcbb9e03002cdd6/addons/account/models/account_move_line_tax_details.py#L92). At the [creation of the second subtable](https://github.com/odoo/odoo/blob/51fcbd211d2b1abf4b93becedbcbb9e03002cdd6/addons/account/models/account_move_line_tax_details.py#L164-L198) the move lines are linked together based among other things on the tax id. The [filter on analytic distribution](https://github.com/odoo/odoo/blob/51fcbd211d2b1abf4b93becedbcbb9e03002cdd6/addons/account/models/account_move_line_tax_details.py#L187-L191) does not apply here as `tax.analytic = False`. The result is that each tax line is linked with both base lines. The second subtable have 4 lines in this case, with each base line doubled. The result of the query have the base amount doubled. Solution: We cannot fix the query as there is no link to find the tax line origin amongst the base lines. The method `_read_generic_tax_report_amounts` in `account_reports` is made to fix the base values in report in case of duplicate. Until now it did not include the duplication caused by analytic distribution but duplication because of repartition lines for example. The fix is to use this method also for analytic distribution. So we add `tdr.analytic_distribution` in the `GROUP BY`. This value must be returned by the query in `account` so we add it. opw-4753676 closes #217789 X-original-commit: 6cde92f Related: odoo/enterprise#89678 Signed-off-by: Laurent Smet (las) <[email protected]> Signed-off-by: Mathieu Coutant (mcou) <[email protected]>
`params` was removed from the action context by 1b86bd7 So `this.props.action.context.params` no longer makes any sense. It looks like it was useless. Everything seems to work without it. Let's remove it. closes #217906 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
accessing 'ongoing_session_count' caused a traceback, because we were calling get() on raw _read_group() results. this commit fixes the issue by storing _read_group() results into a dictionary. closes #217840 Signed-off-by: Matthieu Stockbauer (tsm) <[email protected]>
…ed from sale In Hungary the rate of the currency of an invoice is based on the delivery date. When creating an invoice from Sale, the `currency_rate` of the lines is the one of the invoice date not of the delivery. Steps to reproduce: - Install l10n_hu_edi and witch to Hungarian company - Have two different rates for EUR<->HUF - Create a pricelist in EUR - Create a quotation with the pricelist and confirm - Validate the delivery on another date (which has a different rate from today) - In the sale order click "Create Invoice" - The generated invoice has lines using the rate for today Cause: The field `delivery_date` is `precompute=True` but on creation of the invoice, at the time of the precompute, `line_ids` is still `False`. So the invoice is first computed without the delivery date, the currency rate used is the one of the invoice date. When the delivery date is written on the invoice, the line balance is not recomputed as the field `balance` is marked as `protected`. Solution: As the field `delivery_date` was implemented in `account_move` for localizations including l10n_hu, there are no reason to contain the fix only to l10n_hu. So we add the value of `delivery_date` in the dictionnary used to create a new invoice from sale with the method `_create_invoices`. This way the delivery date is there on creation of the invoice and is used for the currency rate. opw-4756568 closes #217915 X-original-commit: 459803b Signed-off-by: Ruben Gomes (rugo) <[email protected]> Signed-off-by: Mathieu Coutant (mcou) <[email protected]>
The Add Page Dialog was still using a helper that depends on jquery. But this helpers has already been remade without using it, so we can just use it directly without having to load a bundle with jquery. Part-of: #217478 Signed-off-by: Francois Georis (fge) <[email protected]>
The previous code was using deferred for not a particularly good reason. Also, the selectors were wrong, so we always fetched the website. While we are at it, this commit adds a few other small improvements, to avoid fetching multiple times the same data. closes #217478 Signed-off-by: Francois Georis (fge) <[email protected]>
When both l10n_es_pos_tbai and l10n_pe_edi_pos are installed, the refund reason popup was not showing up because we were not awaiting the super method call in the l10n_pe_edi_pos override. runbot-227630 closes #217523 X-original-commit: 63c7355 Related: odoo/enterprise#89534 Signed-off-by: Ruben Gomes (rugo) <[email protected]> Signed-off-by: Robin Engels (roen) <[email protected]>
`edit_megamenu_big_icons_subtitles` tour was previously broken due to DOM structure changes introduced by the new website builder and was consequently disabled. This commit updates the tour steps to align with the new DOM and re-enables the associated test. closes #211471 Signed-off-by: Francois Georis (fge) <[email protected]>
Renamed `print_status` to `status` to conform to the status readable by `iot_http` service. We also removed the automatic event confirmation for actions on printers, as we later send the actual status of the printer (low on paper, not ready, ...). Enterprise PR: odoo/enterprise#89638 closes #217932 Task: 4922613 Signed-off-by: Max Whale (mawh) <[email protected]>
Since [1], the conversion of actions to classes led to improper function repartition, causing tracebacks when using several `DonationOption` options. This commit resolves these tracebacks by moving the code to its correct location without altering its behavior. Additionally, tests have been added to ensure more robustness. Steps to reproduce: - Drop `s_donation` snippet - Click on it - Use any of the following options: "Display Options", "Pre-filled Options", "Descriptions" - Traceback: "this.rebuildPrefilledOptions is not a function" [1]: 4f7c91c Related to task-4367641 closes #217136 Signed-off-by: Benoit Socias (bso) <[email protected]>
Commit [1] added vertical alignment options for the s_floating_blocks cards on mobile, but the icon src was wrong. [1]: 35f1846 task-4367641 closes #217941 Signed-off-by: Francois Georis (fge) <[email protected]>
Following the merge of contracts into versions, a duplicate function _get_duration_batch was created where the old and new ones existed simultaneously with the same function skeleton, this commit removes the old _get_duration_batch closes #217711 Signed-off-by: Bertrand Dossogne (bedo) <[email protected]>
In the [html_builder refactoring] this behavior has been lost. To reproduce the issue: - Open Website and start editing - Add a "Banner" snippet - Click inside => The "spacing" option inputs are empty, but they should display 0. Related to task-4367641 [html_builder refactoring]: 9fe45e2b7ddb closes #217970 Signed-off-by: Francois Georis (fge) <[email protected]>
Scenario: - edit navigation bar to "Rounded box menu" (header_boxed_opt) - select option "Sub Menus" to "On Hover" - add a mega menu - outside of editor, hover the mega menu item and move mouse over it Result: the mega menu content closes before we get to it. History: In saas-18.1 and saas-18.2, these menus with the show on hover have been broken and fixed through different changes: (A) normal popup menu (B) all mega menu (C) mega menu with header_boxed_opt menu bar Here is the list of commit and what was broken after them: - 6715158 (nov 2024): C - b9b3a60 (jan 2025): A+C - ddf0712 (apr 2025): B+C - e65d4cf (apr 2025): C And hopefully this commit will fix C that happen since in 6715158 where we added a !important margin-top to the mega menu in case of header_boxed_opt header that is causing issue C. We do not the the change for a menu inside .o_mega_menu_is_offcanvas because in this case "header_sidebar_opt" doesn't need the fix and needs to have a margin-top because: - it is in the margin-top space that the go back button is - the height is computed taking into account the margin-top, so if we removed it the height of the megamenu+margin-top would not be 100% and there would be a gap at the bottom opw-4876149 closes #217887 X-original-commit: 44560db Signed-off-by: Quentin Smetz (qsm) <[email protected]> Signed-off-by: Nicolas Lempereur (nle) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bt_gitbot