Syncing from upstream odoo/odoo (master) #34200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #217827 X-original-commit: 027d07d Signed-off-by: Ruben Gomes (rugo) <[email protected]> Signed-off-by: Josse Colpaert (jco) <[email protected]>
An error occurs if the Validity Period is removed while creating a new allocation. Steps to reproduce: - Install the 'hr_holidays' module - Time Off > My Time > My Allocation - Open New and remove the 'Validity Period' Traceback: AttributeError: 'bool' object has no attribute 'strftime' This commit ensures that changing the date won't cause an error, but instead will display a warning upon saving the form, as it is a required field. sentry-6709097746 closes #217833 X-original-commit: 70d7842 Signed-off-by: Bertrand Dossogne (bedo) <[email protected]> Signed-off-by: Aayush Modi (aamo) <[email protected]>
Before this commit: 1. Insert an image and add a link to it. 2. Click on the image and remove it by clicking the remove button in the toolbar. 3. The link popover remains open and only disappears after clicking away. This occurs because the default behavior of a link with text preserves the link element to allow the possibility of completely changing the label of the link directly in the editing area. After this commit: We made a override in link_plugin, to handle the delete of an image when its parent element is a link, e.g. image link. The link popover is properly closed when an image link is removed, and the link element is removed when the link element associated with the image is empty. We also improve the media modify handler, move it partially to normalize, ref: #211401 From the ref pr, we unwrap the link in other media plugins when unsupported media type is inserted to a link by replacing the image. In this commit, we move that logic to the link plugin, and do it in the normalize step. By doing this, the dispatching in the ref pr won't be needed. The unwrapping condition is when a link has another link inside it (media type document), or when the link has an inframe inside (video media type, possible in new html_builder website). It's possible that a link has other type of child like img element, font element (background color), span element (icon), t element (template), textnode etc. It's easier to specify in which cases we want to unwrap a link. task-4805029 closes #217699 X-original-commit: 02ef4fb Signed-off-by: David Monjoie (dmo) <[email protected]> Signed-off-by: Jinjiu Liu (jili) <[email protected]>
This commit: e2a0c6e change a help in the intercompany rules. The help sentence is wrong since we don't create invoice but bills. task-4907810 closes #217821 X-original-commit: c7f11ff Related: odoo/enterprise#89701 Signed-off-by: William André (wan) <[email protected]> Signed-off-by: Maximilien La Barre (malb) <[email protected]>
Following the fix in d927a7b, we broke the default behaviour of empty text/chart fields. While the server returns the value `false` when they're empty, we want to display an empty string in the `ODOO.LIST` formulas. Task-4897690 closes #217611 X-original-commit: c6c118c Signed-off-by: Rémi Rahir (rar) <[email protected]> Signed-off-by: Pierre Rousseau (pro) <[email protected]>
* = l10n_in_hr_holidays, l10n_ae_hr_payroll, l10n_be_hr_payroll Steps: - Navigate to Time Off > Configuration > Time Off Types. - Open any time off type form with localization or payroll-related options. Issues: - Configuration fields (including localization modules) appeared misaligned. - The Payroll section was not utilizing space effectively in the layout. Fix: - Aligned all configuration fields in a consistent two-column layout, including localization and payroll-related options., - Repositioned the Payroll section below the Negative Cap section. Task - 4759116 closes #213487 Related: odoo/enterprise#87274 Signed-off-by: Yannick Tivisse (yti) <[email protected]>
Currently, when creating a refund, the move type selector shows all possible move_type out there. We obviously don't want that... Solution: show only the current move type for refunds. task-4926014 closes #217849 X-original-commit: 2977874 Signed-off-by: Ruben Gomes (rugo) <[email protected]> Signed-off-by: Antoine Boonen (aboo) <[email protected]>
* = html_editor, mail A BottomSheet is a UI component in mobile apps that slides up from the bottom of the screen to display additional content or options. It can be partially or fully expanded and is commonly used for actions, menus, or forms. BottomSheets provide a non-intrusive way to show relevant information without leaving the current screen. This commit adds: * BottomSheet Component * Dynamic Viewport Units (DVU) hook * Feature Detection (virtualKeyboard) * Adapt Popover service to use BottomSheet Component * All Dropdown are show in bottom sheet * Adapt code to support `prefers-reduced-motion` * IMP kanban color picker in menu * CSS tweak: stats button, "switch view" * CSS adapt home menu navbar (box-shadow) * CSS scroll-state when more content in sheet (content not visible) * Disable bottom sheet for search bar * Disable bottom sheet for some dropdown of HTML Editor * Disable bottom sheet for activity menu and messaging menu task-4551522 closes #216854 Related: odoo/enterprise#89119 Signed-off-by: Pierre Paridans (app) <[email protected]> Co-authored-by: Romeo Fragomeli <[email protected]> Co-authored-by: Luca Vitali <[email protected]>
The dict contained 2 different examples for a tax number in Japan. Keeping the one that is matching the company registry example, but positionning it correctly in the dict. closes #217805 X-original-commit: af607be Signed-off-by: Josse Colpaert (jco) <[email protected]> Signed-off-by: William André (wan) <[email protected]>
Use markup template and html functions to make the code cleaner and safer while no longer triggering ci/security flag. closes #216275 Signed-off-by: Géry Debongnie <[email protected]>
Use markup template and html functions to make the code cleaner and safer while no longer triggering ci/security flag. closes #216340 Signed-off-by: Géry Debongnie <[email protected]>
…p tests The test_expected_date_with_storable_product, introduced in #204243, failed when running single-app tests for the sale module because it relies on the sale_delay field defined in the stock module. To avoid this issue, the test has been moved to the `sale_stock` module, ensuring the test suite passes in all configurations. closes #217885 Signed-off-by: Steve Van Essche <[email protected]>
Waiting an animationFrame after each click (fix done in [1]) was not sufficient, we actually need to wait for 2 or 3 separate ticks depending on the case, because `customizeWebsiteColors` calls between 2 and 3 debounced functions (`debouncedSCSSColorsCusto`, possibly `debouncedSCSSVariablesCusto`, and finally `reloadBundles`) with a 0-ms delay. [1]: cbcd1b1 runbot-229604 runbot-229686 closes #217897 X-original-commit: 0b9b1a0 Signed-off-by: Francois Georis (fge) <[email protected]> Signed-off-by: Robin Lejeune (role) <[email protected]>
Part-of: #216638 Related: odoo/enterprise#89233 Signed-off-by: Michaël Mattiello (mcm) <[email protected]>
Part-of: #216638 Related: odoo/enterprise#89233 Signed-off-by: Michaël Mattiello (mcm) <[email protected]>
We introduce a new operator "in range" for the date/datetime fields. It more or less replaces several other operators that are removed: between, not_between, today, not_today, last, not_last, next, not_next. The new operator allows to easily select several dynamic time ranges: Today, Last 7 days, Last 30 days, Month to date, Last month, Year to date, Last 12 months or a custom range given by 2 dates/datetimes. We also remove the ends_with operator and reduce the lists of operators available for selection for most of the field types. Task ID: 4894524 closes #216638 Related: odoo/enterprise#89233 Signed-off-by: Michaël Mattiello (mcm) <[email protected]>
The test in this module imports a common setup from account_reports which is not a dependency, and is not auto installed when the test runs with comunity modules only. This fix replaces the setup by the community one AccountTestInvoicingCommon. closes #217837 X-original-commit: 591acd3 Signed-off-by: Jinane Maksoud (maji) <[email protected]>
In this commit, we move step_utils to the root of web_tour/static/src. The goal is to move all the files that are in tour_service into web_tour/static/src and then split it into tour_automatic and tour_interactif in order to create 2 separate bundles and be able to lazy load what tour_automatic needs only when we launch an automatic tour. closes #217854 Related: odoo/enterprise#89712 Related: odoo/design-themes#1111 Signed-off-by: Pierre Pulinckx (pipu) <[email protected]>
A blocking error is too much, because it impedes the automatic sync flow. Warnings have been added to the `i18n` command and the base_language_export wizard. A retry / more button has been added, in case the user wants to export something else. The title was changing to the default Odoo after switching state. Now it stays Export Translation closes #217747 X-original-commit: 5192edc Signed-off-by: Chong Wang (cwg) <[email protected]> Signed-off-by: Paolo Gatti (pgi) <[email protected]>
Before this commit, components created by the public component services did not interact very well with the editor. For example, it was possible to save the content of the dom of the component in the page, which meant that once the component was mounted, it would look like we have 2 components, one of them inactive, and the other active. This commit fixes the issue by mounting the component in an interaction, so the lifecycle should be properly handled. X-original-commit: bc038f8 Part-of: #217673 Signed-off-by: Francois Georis (fge) <[email protected]>
With this commit, we introduce a public_component.edit registry to explicitely declare that a owl-component should be active in edit mode. By default, the code will fall back on the public_components registry, but it will add a pointer-events: none style attribute to make sure that such components are inactive in edit mode, which is most likely what we want. closes #217673 X-original-commit: 3841ae0 Signed-off-by: Francois Georis (fge) <[email protected]>
* = calendar, crm_livechat, hr_holidays, im_livechat, project, rating, website_livechat, website_slides There are many flows in which we need to build Store data for a specific target, as different targets have different needs and different ACL. For example, we usually don't want to send email address to non-internal users as this is considered a private data. However we are fine with returning the email address to internal users by default. This is currently implemented with `for_current_user` on a case by case (specific store methods of specific models), which leads to inconsistencies and carelessness: some models have for_current_user as False by default, other as True, some would need the param but currently don't define it, some methods check if the current user is internal but don't verify the target at all (internal users can broadcast to other non-internal users), etc. This commits brings this feature in a more robust way directly into the Store. X-original-commit: 9128981 Part-of: #217745 Related: odoo/enterprise#89650 Signed-off-by: Matthieu Stockbauer (tsm) <[email protected]> Signed-off-by: Sébastien Theys (seb) <[email protected]>
The email pop in _to_store of partner is especially problematic as it doesn't allow to set the email of a partner in a store for the portal user even in flows where it would be acceptable, which is necessary in some other tasks. On top of that we want to remove this method as we have better ways to express the intent of storing a value in the store with the other existing methods. task-4676468 closes #217745 X-original-commit: 3c5d367 Related: odoo/enterprise#89650 Signed-off-by: Matthieu Stockbauer (tsm) <[email protected]> Signed-off-by: Sébastien Theys (seb) <[email protected]>
Use markup template and html functions to make the code cleaner and safer while no longer triggering ci/security flag. closes #216159 Related: odoo/enterprise#88683 Signed-off-by: Matthieu Stockbauer (tsm) <[email protected]>
closes #217742 Signed-off-by: Francois Georis (fge) <[email protected]>
Use markup template and html functions to make the code cleaner and safer while no longer triggering ci/security flag. closes #216306 Signed-off-by: Géry Debongnie <[email protected]>
Issue: Copying a bom with an operation will not reassign the copied operation to the by product lines. Steps to reproduce: - In the settings enable operations and by-products - Create a bom with an operation op1 and a by product produced in op1 - Copy the bom > The copied by product line refer to the operation of the original bom > this can be checked by archiving the copied operation which should > erase its link with the copied by product line but will not Cause of the issue: When a bom is copied, the new operation is reassigned to the new bom lines by these lines: https://github.com/odoo/odoo/blob/9cb4230a6b2252243a8e0546a1a8f5bc52e74009/addons/mrp/models/mrp_bom.py#L230-L247 However, nothing is made for the by product lines. opw-4788252 closes #217846 X-original-commit: 75668dd Signed-off-by: William Henrotin (whe) <[email protected]> Signed-off-by: Lancelot Semal (lase) <[email protected]>
Issue: When having two lines on an invoice with the same tax and different analytic distribution, the base value is doubled on the tax report. Steps to reproduce: - Create a new taxe on sales (eg 10%) - Make sure the option "Analytic Accounting" is ticked in the settings - Create an invoice with two lines (eg both at $100), add the tax on both - Change the analytic distribution on both lines to different values - Confirm the invoice - Go to the tax report - Select the report "Group By: Account > Tax" - On the report the "Net" amount is doubled ($400), the tax amount is correct ($20) Cause: On the invoice we can see in "Journal Items" that two tax lines are created instead of one (one for each analytic distribution). The "Group By" reports are generated by [this query](https://github.com/odoo/odoo/blob/51fcbd211d2b1abf4b93becedbcbb9e03002cdd6/addons/account/models/account_move_line_tax_details.py#L92). At the [creation of the second subtable](https://github.com/odoo/odoo/blob/51fcbd211d2b1abf4b93becedbcbb9e03002cdd6/addons/account/models/account_move_line_tax_details.py#L164-L198) the move lines are linked together based among other things on the tax id. The [filter on analytic distribution](https://github.com/odoo/odoo/blob/51fcbd211d2b1abf4b93becedbcbb9e03002cdd6/addons/account/models/account_move_line_tax_details.py#L187-L191) does not apply here as `tax.analytic = False`. The result is that each tax line is linked with both base lines. The second subtable have 4 lines in this case, with each base line doubled. The result of the query have the base amount doubled. Solution: We cannot fix the query as there is no link to find the tax line origin amongst the base lines. The method `_read_generic_tax_report_amounts` in `account_reports` is made to fix the base values in report in case of duplicate. Until now it did not include the duplication caused by analytic distribution but duplication because of repartition lines for example. The fix is to use this method also for analytic distribution. So we add `tdr.analytic_distribution` in the `GROUP BY`. This value must be returned by the query in `account` so we add it. opw-4753676 closes #217817 X-original-commit: 6cde92f Related: odoo/enterprise#89697 Signed-off-by: Laurent Smet (las) <[email protected]> Signed-off-by: Mathieu Coutant (mcou) <[email protected]>
**Problem:** When refunding an order that has been paid using a reward system, the points are deducted again as if the client made another purchase using those points. This means that in the case of a refund, the client would not only lose those points but have to spend them again. **Steps to reproduce:** - Make a purchase in POS using a reward such as $1 for every point - Refund this purchase - The points are deducted again **Why the fix:** The points do not need to be refunded after a refund, but they don't have to be paid again. The total point for this refund order is now set to zero in case of a refund. This means the transaction will not be visible on the Coupon Card in the Loyalty Program. opw-4771724 closes #217896 X-original-commit: 753ca8b Signed-off-by: David Monnom (moda) <[email protected]> Signed-off-by: Arthur Nanson (artn) <[email protected]>
The upgrade script from saas-18.3 to saas-18.4 converting the default value of text filter is wrong. It didn't account for the empty string which should be considered as "no default value" `defaultValue: "hello"` --> `defaultValue: ["hello"]` correct `defaultValue: ""` --> `defaultValue: [""]` not correct closes #217943 Task: 4926326 X-original-commit: 262e56e Signed-off-by: Pierre Rousseau (pro) <[email protected]> Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
…ncy on expense report When generating an expense report for an expense recorded in a currency different from the company's, the totals were shown with the symbol of the expense's currency, even though the amounts were actually in the company's currency. opw-4807756 closes #218126 X-original-commit: dc384e6 Signed-off-by: Olivier Colson (oco) <[email protected]>
…e-text link reproduction: 18.0+18.1: 1. In Todo, insert an inline image, and create a link including the image and some text 2. click on the text part, click edit button, modify the label area and click apply 3. the image is removed Test case 2: 1. go to Recruitment, and open an application and click "Send interview" 2. click on the link inside the template, change the url 3. apply, format of the button breaks 18.2: same flow with test case 2, click apply causing a traceback 18.3: same flow with test case 2, click on the link, do nothing and click away, the popover not close Fix: a partial back port of odoo-dev#4633 The idea is that when the link doesn't only contain text, we don't show the label input field nor apply the label to the link. Because the label field extracts/display the text content of the link element, the field doesn't support html fragment, applying the label on a link including another element inside will break it. on 18.4+, we only rename the variable from isLabelHidden to showLabel task-4881878 closes #217558 X-original-commit: 51895df Signed-off-by: David Monjoie (dmo) <[email protected]> Signed-off-by: Jinjiu Liu (jili) <[email protected]>
pos_epson_printer, pos_self_order, pos_restuarant In this commit: - Enhance error handling by sending more descriptive and user-friendly messages to the Point of Sale interface when Epson printer errors occur. This provides better insight into printing issues, helping users quickly identify and resolve problems. task-4756143 closes #208958 Signed-off-by: Stéphane Vanmeerhaeghe (stva) <[email protected]>
The previous hashCode algorithm produced was distribution-dependent results, causing errors in the Runbot's nightly tests for different distributions. The new hashCode algorithm is the same as the one used in Hoot [1], and this algorithm produces non-distribution-dependent results. [1]: https://github.com/odoo/odoo/blob/4d7e941939b2d8b644cbf0d9a5a0aa2bb8d4c9e8/addons/web/static/lib/hoot/hoot_utils.js#L941 runbot-error : 227626 closes #218156 X-original-commit: 8982043 Signed-off-by: Lucas Perais (lpe) <[email protected]> Signed-off-by: Jorge Pinna Puissant (jpp) <[email protected]>
In order to satisfy certification requirements from the LNE, we implement the following: - A product is weighed at e.g. 200g and added to the order - Another product is weighed. The weight must change from 200g before the user is allowed to add the item. - This should also happen even if another non-weighed product is added in-between. task-4859589 closes #218155 X-original-commit: 29a2ab8 Related: odoo/enterprise#89861 Signed-off-by: Yaroslav Soroko (yaso) <[email protected]> Signed-off-by: Max Whale (mawh) <[email protected]>
Versions -------- - 17.0+ Steps ----- 1. Configure website to display prices tax-included; 2. disable selling out-of-stock products; 3. go to an out-of-stock product page; 4. request a reminder email; 5. replenish product stock; 6. run the `_send_availability_email` action; 7. check email that was sent. Issue ----- The price display in the email does not include taxes. Cause ----- The email only checks the `list_price` defined on the product. Solution -------- Don't include the price in the email: - On stable: hide the element to avoid breaking xpaths - On master: remove the element from the template opw-4712613 closes #218146 X-original-commit: 22c333d Signed-off-by: Levi Siuzdak <[email protected]>
Renamed `print_status` to `status` to conform to the status readable by `iot_http` service. We also removed the automatic event confirmation for actions on printers, as we later send the actual status of the printer (low on paper, not ready, ...). Enterprise PR: odoo/enterprise#89638 closes #218075 Task: 4922613 X-original-commit: de6b637 Related: odoo/enterprise#89826 Signed-off-by: Max Whale (mawh) <[email protected]> Signed-off-by: Louis Travaux (lotr) <[email protected]>
- Make `invoice_currency_rate` editable. - Add a date picker widget that let the user apply the rate of a certain date. - Add a refresh button when the rate is not the expected one. To that end, the computed field `expected_currency_rate` is added. task-4378994 closes #218056 X-original-commit: 2d486fb Signed-off-by: William André (wan) <[email protected]> Signed-off-by: Arnaud Sibille (arsi) <[email protected]>
Fixing wrong operator introduced in c594781. closes #217860 Signed-off-by: Chong Wang (cwg) <[email protected]>
* = im_livechat, website_livechat, test_discuss_full This commit stores the `mute_until_dt` field on the channel member record instead of the channel. Task-4851890 closes #217331 Signed-off-by: Sébastien Theys (seb) <[email protected]>
When [1] introduced a cached version of the form data to compute visibility, it did not take into account the values that are completed through `prefillValues`. Because of this, input events are required for those to be taken into account. This commit fixes this by re-evaluating the form content after the execution of `prefillValues`. Steps to reproduce: - Drop a "Form" snippet - Make "Your Question" field visible only if "Your Email" is set. - Save page. => Upon display, the email is populated with the user's email, but "Your Question" did not become visible. [1]: 027ce4e task-jke closes #218137 X-original-commit: 3682459 Signed-off-by: Francois Georis (fge) <[email protected]>
…rch panel Before this commit: - Long dashboard names were truncated in the search panel. - There was no way for the user to see the full name. After this commit: - A tooltip has been added to display the full dashboard name on hover. closes #218129 Task: 4903713 X-original-commit: b5c291a Signed-off-by: Pierre Rousseau (pro) <[email protected]> Signed-off-by: Ronakkumar Mukeshbhai Bharadiya (rmbh) <[email protected]>
This fixes some rendering issues with the payroll tab. closes #218063 Task: 4885749 X-original-commit: 6efb968 Related: odoo/enterprise#89819 Signed-off-by: Yannick Tivisse (yti) <[email protected]> Signed-off-by: Arthur Pierrot (arpi) <[email protected]>
When an image is added from a CORS URL, the image data cannot be obtained from the web browser. Because of this, converting the image to another format, adjusting its quality or other manipulations are not possible. Currently the "Quality" option appears for CORS image - but disappear when trying to use it, which also corrupts the image. This commit hides the "Quality" option when converting to another format is anyway unavailable. Steps to reproduce: - drop an image block - replace an image by using "Add URL" and specify a [non-CORS image] - "Quality" option was available and could be used - replace an image by using "Add URL" and specify a [CORS image] => "Quality" option was available, but should not have been. Upon use, image was lost and "Quality" option disappeared. [non-CORS image]: https://upload.wikimedia.org/wikipedia/commons/thumb/2/2f/Thysanoptera.jpg/420px-Thysanoptera.jpg [CORS image]: https://tinyjpg.com/images/social/website.jpg task-4367641 closes #218060 X-original-commit: b0c513c Signed-off-by: Francois Georis (fge) <[email protected]>
closes #217946 X-original-commit: 3b472f4 Signed-off-by: Francois Georis (fge) <[email protected]>
When both l10n_es_pos_tbai and l10n_pe_edi_pos are installed, the refund reason popup was not showing up because we were not awaiting the super method call in the l10n_pe_edi_pos override. runbot-227630 closes #217931 X-original-commit: 63c7355 Related: odoo/enterprise#89748 Signed-off-by: Ruben Gomes (rugo) <[email protected]> Signed-off-by: Robin Engels (roen) <[email protected]>
The purpose is to make field.condition_to_sql() independent from access rights. This is necessary in the case of related_sudo fields, where the condition must be evaluated but without checking field access. Part-of: #210601 Related: odoo/enterprise#85894 Signed-off-by: Raphael Collet <[email protected]>
The purpose is to factor out the code that introduces LEFT JOINs for many2one relations. Part-of: #210601 Related: odoo/enterprise#85894 Signed-off-by: Raphael Collet <[email protected]>
More tests is more good, especially to show where access rules are introduced in subqueries. Part-of: #210601 Related: odoo/enterprise#85894 Signed-off-by: Raphael Collet <[email protected]>
The new operators 'any!' and 'not any!' bypass access rights (including record rules) on the comodel. Otherwise, they behave just like the operators 'any' and 'not any!', respectively. This operator cannot be accepted through RPC, to avoid users bypassing security checks. The new operator is considered internal. When transforming a list into a Domain, we do not allow for internal operators. We still need to accept parsing a domain like this for return values of `_search` methods, though. Part-of: #210601 Related: odoo/enterprise#85894 Signed-off-by: Raphael Collet <[email protected]>
This provides a compatibility layer for field search methods that do not implement operator 'any!'. Part-of: #210601 Related: odoo/enterprise#85894 Signed-off-by: Raphael Collet <[email protected]>
The purpose is to cover all special cases like binary, one2many and many2many fields, and the effect of related_sudo, that gives access to the target field but does not sudo() searches on 'any' domains. Part-of: #210601 Related: odoo/enterprise#85894 Signed-off-by: Raphael Collet <[email protected]>
This was already doable for grouping, aggregating and ordering on such
fields. We now also use joins for searching.
For the implementation, we rely on the operator 'any!', which generates
SQL joins when used with many2one fields. Conditions on a related field
like foo.bar.baz are basically rewritten like:
(field, operator, value) =>
(foo, 'any!', [(bar, 'any!', [(baz, operator, value)])]) if related_sudo
(foo, 'any', [(bar, 'any', [(baz, operator, value)])]) otherwise
closes #210601
Related: odoo/enterprise#85894
Signed-off-by: Raphael Collet <[email protected]>
Before this commit an error can appear if there two delivery line. Use method in delivery module to compute delivery amont. This method can compute if there are two line with delivery https://github.com/odoo/odoo/blob/18.0/addons/delivery/models/sale_order.py#L27 closes #218180 X-original-commit: 173de20 Signed-off-by: Antoine Vandevenne (anv) <[email protected]>
The Add Page Dialog was still using a helper that depends on jquery. But this helpers has already been remade without using it, so we can just use it directly without having to load a bundle with jquery. Part-of: #218073 Signed-off-by: Francois Georis (fge) <[email protected]> Signed-off-by: Géry Debongnie <[email protected]>
The previous code was using deferred for not a particularly good reason. Also, the selectors were wrong, so we always fetched the website. While we are at it, this commit adds a few other small improvements, to avoid fetching multiple times the same data. closes #218073 Signed-off-by: Francois Georis (fge) <[email protected]> Signed-off-by: Géry Debongnie <[email protected]>
…repr *: test_discuss_full task-4676112 closes #212915 Signed-off-by: Sébastien Theys (seb) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bt_gitbot