-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift bindings #716
Closed
ScottThomasMiller
wants to merge
37
commits into
brainflow-dev:master
from
ScottThomasMiller:swift-bindings
Closed
Swift bindings #716
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
e2d0f24
Swift Bindings with updated cmake files and standalone executable CI …
ScottThomasMiller 00ab3b3
trying to fix build error from SPM
ScottThomasMiller d376386
removed Package.resolved and xcode clean commands
ScottThomasMiller 6f751b3
removed BrainFlowCITests.swift from all targets
ScottThomasMiller b81e571
removed all references to BrainFlowTests
ScottThomasMiller ec5faa5
set exact version of swift-argument-parser
ScottThomasMiller c9e699b
set exact version of swift-argument-parser to 1.2.0
ScottThomasMiller 1f25c6a
using destination OS X
ScottThomasMiller 0e47557
platform=macOS, arch=x86_64
ScottThomasMiller 26bd97e
removed space from destination parameter
ScottThomasMiller 19960d4
removed code signing
ScottThomasMiller d94cce8
added Frameworks directory and updated gitignore
ScottThomasMiller 6bdb626
added cp commands for the Frameworks subdirectory
ScottThomasMiller f255cf2
added arm64 and updated simpleble make file
ScottThomasMiller cd2921a
removed arm64 destination
ScottThomasMiller ab3ed47
using xcodebuild install
ScottThomasMiller dfbade1
embed without signing and copy-on-install
ScottThomasMiller 4e646ad
pared-down yml for expedited troubleshooting
ScottThomasMiller 41371de
added troubleshooting ls and otool commands
ScottThomasMiller 25002c3
added troubleshooting ls and otool commands take II
ScottThomasMiller e29e21a
unchecked copy on install
ScottThomasMiller 7c1a543
troubleshooting image not found error
ScottThomasMiller 192b959
added runpath search paths
ScottThomasMiller a3d1137
changed embedding location to executables
ScottThomasMiller 950fe6f
commented out ls commands
ScottThomasMiller b350a25
add ls install
ScottThomasMiller 9caaefb
disabled library validation
ScottThomasMiller 56884af
disable library validation for all
ScottThomasMiller 7b46896
re-added build commands
ScottThomasMiller 3f05e05
reverted run unix to confirm all other CI is OK
ScottThomasMiller fbaaa7c
really reverted it this time
ScottThomasMiller a2c526a
known good Swift CI
ScottThomasMiller 9982ba8
cleanup for initial PR
ScottThomasMiller 322c29c
Merge branch 'master' into swift-bindings
Andrey1994 ba868be
finished cleanup
ScottThomasMiller 42ceaf4
PR cleanup third pass
ScottThomasMiller 8d8050f
fixed linker error
ScottThomasMiller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copypasting files is not good, I actually thought that its smth like package. e.g. https://www.swiftyplace.com/blog/modular-code-with-swift-package-manager
Can also publish it on github packages later on. BrainFlowCI should use it as a package also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating the package is an important feature, but it is also a challenge and will take a while. I've tried several times over the years but failed each time. I will most likely have to open a help ticket with Apple Developer Support. I cannot promise a delivery date for this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://developer.apple.com/documentation/xcode/creating-a-standalone-swift-package-with-xcode here is a good guide how to create it, I believe the 1st step should be to separate BrainFlowCI and BrainFlowBinding to different projects, create a package like described in the article and after that try to use this package in CI apps