-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brightness normalisation #25
Open
IgorTatarnikov
wants to merge
15
commits into
main
Choose a base branch
from
brightness-normalisation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 95.54% 96.95% +1.41%
==========================================
Files 6 6
Lines 673 756 +83
==========================================
+ Hits 643 733 +90
+ Misses 30 23 -7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
There can be large intensity differences between each tile. This PR introduces a method to normalise the intensities between each tile.
What does this PR do?
This is done by assuming that the overlapping area should have equal intensity between each tile. This is used to calculate a scaling factor between two tiles. This scaling factor is applied and the comparison is done for the subsequent tiles. For example say an image contains 4 tiles and each tile overlaps with all other tiles:
The first round of comparisons will calculate scaling factors for tile 1 + 2, 1 + 3, 1 + 4. The scaling factors will be applied lazily to the tiles. The second round of comparisons will calculate scaling factors based on tile 2 + 3, 2 + 4.
The final result will be a
num_tiles
bynum_tiles
matrix that contains a scaling factor for each tile comparison.The final factor is calculated as the product of all scaling factors calculated for that tile. This final scaling factor is then applied to the full resolution image prior to fusing/saving to disk.
How has this PR been tested?
Tests added for new functionality.
Is this a breaking change?
No
Checklist: