-
Notifications
You must be signed in to change notification settings - Fork 2
Add source_to_raw function #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
K-Meech
wants to merge
24
commits into
main
Choose a base branch
from
km/source_to_raw
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
List of changes to be made, before bring out of draft:
|
…der into km/source_to_raw
…der into km/source_to_raw
Contributor
Author
|
I think this PR is ready to review now - I've implemented the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Currently, atlas example scripts repeat much of the same processing. This PR aims to abstract the main standardisation steps into a re-useable function: source_to_raw
What does this PR do?
Bundles standardisation steps into a re-useable function - see brainglobe/atlas-forge#10 (comment) for an overview of the various steps agreed for the two main processing steps: source_to_raw and raw_to_ready.
The downsampling step is still marked as todo, as I will implement this in a separate PR. See discussion on the source_to_raw issue.Feedback on any part of this is very welcome!
References
brainglobe/atlas-forge#13
How has this PR been tested?
Automated tests have been added for all parts of
source_to_raw, and I have also tested locally on some example Zebrafinch images and masks.Is this a breaking change?
No
Does this PR require an update to the documentation?
Docstrings have been added for all. We'll add documentation for the overall pipeline once both
source_to_rawandraw_to_readyare merged.Checklist: