Skip to content

Conversation

@K-Meech
Copy link
Contributor

@K-Meech K-Meech commented Nov 17, 2025

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Currently, atlas example scripts repeat much of the same processing. This PR aims to abstract the main standardisation steps into a re-useable function: source_to_raw

What does this PR do?

Bundles standardisation steps into a re-useable function - see brainglobe/atlas-forge#10 (comment) for an overview of the various steps agreed for the two main processing steps: source_to_raw and raw_to_ready.

The downsampling step is still marked as todo, as I will implement this in a separate PR. See discussion on the source_to_raw issue.

Feedback on any part of this is very welcome!

References

brainglobe/atlas-forge#13

How has this PR been tested?

Automated tests have been added for all parts of source_to_raw, and I have also tested locally on some example Zebrafinch images and masks.

Is this a breaking change?

No

Does this PR require an update to the documentation?

Docstrings have been added for all. We'll add documentation for the overall pipeline once both source_to_raw and raw_to_ready are merged.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@K-Meech
Copy link
Contributor Author

K-Meech commented Nov 19, 2025

List of changes to be made, before bring out of draft:

@K-Meech K-Meech mentioned this pull request Nov 19, 2025
7 tasks
@K-Meech K-Meech changed the title Draft of source_to_raw function Add source_to_raw function Nov 28, 2025
@K-Meech K-Meech marked this pull request as ready for review November 28, 2025 11:33
@K-Meech K-Meech requested a review from a team November 28, 2025 11:33
@K-Meech
Copy link
Contributor Author

K-Meech commented Nov 28, 2025

I think this PR is ready to review now - I've implemented the source_to_raw function + corresponding tests. I imagine much of the logic for creating test data / csvs etc. will be shared between this PR and the raw_to_ready one, so once these are in we may have to do a follow-up PR to refactor common/similar functions into a shared location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants