Remove SWC file repair method #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And more generally, I think it's better to handle I/O issues from MorphIO instead of trying to patch things up from morphapi. So when someone have I/O issues you can forward him to MorphIO issues. |
adrien-berchet
approved these changes
Apr 26, 2024
alessandrofelder
approved these changes
Apr 26, 2024
IgorTatarnikov
added a commit
that referenced
this pull request
Nov 11, 2024
IgorTatarnikov
added a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
repair_swc_file()method. This doesn't seem to be needed and causes problems by "fixing" problems that don't necessarily exist.I'm removing this on the advice of @adrien-berchet as I don't know much about SWC files! Hopefully this will fix problems like this one. If all else fails, we can revert.
Existing morphapi and brainrender tests pass as they did before (that is to say, not entirely!). No tests added as this PR just removes code. Just after I closed #47 there seems to be an issue with neuromorpho though :(
Closes #59