e2e: refactor TLS helpers #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
stlaz
commented
Nov 26, 2024
stlaz
commented
- simplification of the current certgen code
- better separation of leaf and CA certs in kube CMs/Secrets
stlaz
added
the
sig-auth-acceptance
alegacy
reviewed
Nov 26, 2024
| _, err = client.CoreV1().Secrets(ctx.Namespace).Create(context.TODO(), &corev1.Secret{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: secretName, | ||
| }, | ||
| Data: map[string][]byte{ | ||
| "tls.crt": pem.EncodeToMemory(&pem.Block{ |
alegacy
approved these changes
Nov 26, 2024
|
The test failed on KRP logging |
|
Looks like the same test failed again, that shouldn't happen. I'll have a look. |
|
Still not able to reproduce locally. Raising nginx loglevel to debug in CI. |
Unify cert template generation. SKID and AKID should be properly computed by Golang, no need to add them explicitly - unless we need explicit SKID but that's not the case in our tests.
The previous design was mixing CA and leaf certificates, making it easy to confuse them at place of use. Have all the leaf cryptomaterial in a secret, and the trust in the CM to avoid those issues.
stlaz
force-pushed
the
e2e_cryptorefactor
branch
from
afd6e94 to
daccc4d
Compare
stlaz
force-pushed
the
e2e_cryptorefactor
branch
from
2959053 to
48dfc38
Compare
|
Looks like the test was missing assumptions on when it's safe to be run. I'll give it a couple respins to check the timing issue is now gone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.