Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused variable from deep.c #275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

r-barnes
Copy link

Causes -Wunused-but-set-variable to pass

Causes `-Wunused-but-set-variable` to pass
@brandon-rhodes
Copy link
Owner

@r-barnes — Could you outline your situation; are you working with tools that set that -W flag unilaterally? If so, then we might want to pivot the XEphem build to do the check itself, so that we don't break it again in the future without knowing it.

@r-barnes
Copy link
Author

@brandon-rhodes - I am working in a large codebase with a custom build system that applies -Wunused-but-set-variable to allow our code as well as to third-party code.

I don't have numbers handy (though I could generate them), but enabling -Wunused-but-set-variable has helped us identify a lot of dead code and more than a few bugs. If you're interested in enabling the flag, that'd be swell. I'm otherwise just passing fixes upstream as I go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants