[Draft] Cosmetic filter flatbuffers #496
Draft
+867
−191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
| Benchmark suite | Current: a808475 | Previous: 4738d3f | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
2884995961 ns/iter (± 14387169) |
2252126465 ns/iter (± 13369021) |
1.28 |
rule-match-first-request/brave-list |
1075580 ns/iter (± 8246) |
1000284 ns/iter (± 8364) |
1.08 |
blocker_new/brave-list |
148216683 ns/iter (± 872541) |
150674514 ns/iter (± 1975624) |
0.98 |
blocker_new/brave-list-deserialize |
62129300 ns/iter (± 1064525) |
62360204 ns/iter (± 1865060) |
1.00 |
memory-usage/brave-list-initial |
11526962 ns/iter (± 3) |
16225933 ns/iter (± 3) |
0.71 |
memory-usage/brave-list-initial/max |
64817658 ns/iter (± 3) |
64817658 ns/iter (± 3) |
1 |
memory-usage/brave-list-initial/alloc-count |
1514846 ns/iter (± 3) |
1514650 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-1000-requests |
2516487 ns/iter (± 3) |
2505592 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-1000-requests/alloc-count |
66556 ns/iter (± 3) |
66070 ns/iter (± 3) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: a808475 | Previous: 4738d3f | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
2884995961 ns/iter (± 14387169) |
2252126465 ns/iter (± 13369021) |
1.28 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.