[Draft] Cosmetic filter fb v3: full migration by atuchin-m · Pull Request #497 · brave/adblock-rust

atuchin-m · 2025-08-07T20:05:41Z

DO NOT MERGE

The PR moves from per-NetworkList flatbuffers to a one (per-Engine). It doesn't affect the performance metrics, but opens a possibility to put cosmetic filters to the same flatbuffer. It also simplifies the serialization/deserialization code.

github-actions

Rust Benchmark

Details

Benchmark suite	Current: `f087a7b`	Previous: `4738d3f`	Ratio
`rule-match-browserlike/brave-list`	`2859316369` ns/iter (`± 26370025`)	`2252126465` ns/iter (`± 13369021`)	`1.27`
`rule-match-first-request/brave-list`	`1093627` ns/iter (`± 7231`)	`1000284` ns/iter (`± 8364`)	`1.09`
`blocker_new/brave-list`	`153748871` ns/iter (`± 1079694`)	`150674514` ns/iter (`± 1975624`)	`1.02`
`blocker_new/brave-list-deserialize`	`63334161` ns/iter (`± 907905`)	`62360204` ns/iter (`± 1865060`)	`1.02`
`memory-usage/brave-list-initial`	`8803460` ns/iter (`± 3`)	`16225933` ns/iter (`± 3`)	`0.54`
`memory-usage/brave-list-initial/max`	`64817626` ns/iter (`± 3`)	`64817658` ns/iter (`± 3`)	`1.00`
`memory-usage/brave-list-initial/alloc-count`	`1547531` ns/iter (`± 3`)	`1514650` ns/iter (`± 3`)	`1.02`
`memory-usage/brave-list-1000-requests`	`2516439` ns/iter (`± 3`)	`2505592` ns/iter (`± 3`)	`1.00`
`memory-usage/brave-list-1000-requests/alloc-count`	`66508` ns/iter (`± 3`)	`66070` ns/iter (`± 3`)	`1.01`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions · 2025-08-07T20:09:38Z

src/filters/unsafe_tools.rs

-    pub(crate) fn filter_list(&self) -> fb::NetworkFilterList<'_> {
-        unsafe { fb::root_as_network_filter_list_unchecked(self.data()) }
+    pub(crate) fn root(&self) -> fb::Engine<'_> {
+        unsafe { fb::root_as_engine_unchecked(self.data()) }


_{reported by reviewdog 🐶}
[semgrep] Detected 'unsafe' usage, please audit for secure usage

Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage

Cc @thypon @kdenhartog

github-actions · 2025-08-07T20:09:38Z

src/flatbuffers/fb_network_filter_generated.rs

+                        flatbuffers::Vector<'a, flatbuffers::ForwardsUOffset<&'a str>>,
+                    >>(Engine::VT_COMPLEX_ID_RULES_INDEX, None)
+                    .unwrap()
+            }


_{reported by reviewdog 🐶}
[semgrep] Detected 'unsafe' usage, please audit for secure usage

Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage

Cc @thypon @kdenhartog

github-actions · 2025-08-07T20:09:38Z

src/flatbuffers/fb_network_filter_generated.rs

+                        flatbuffers::Vector<'a, flatbuffers::ForwardsUOffset<&'a str>>,
+                    >>(Engine::VT_COMPLEX_ID_RULES_VALUES, None)
+                    .unwrap()
+            }


_{reported by reviewdog 🐶}
[semgrep] Detected 'unsafe' usage, please audit for secure usage

Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage

Cc @thypon @kdenhartog

github-actions · 2025-08-07T20:09:38Z

src/flatbuffers/fb_network_filter_generated.rs

+                        None,
+                    )
+                    .unwrap()
+            }


_{reported by reviewdog 🐶}
[semgrep] Detected 'unsafe' usage, please audit for secure usage

Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage

Cc @thypon @kdenhartog

github-actions · 2025-08-07T20:09:38Z

src/flatbuffers/fb_network_filter_generated.rs

+                        flatbuffers::Vector<'a, flatbuffers::ForwardsUOffset<&'a str>>,
+                    >>(Engine::VT_HOSTNAME_HIDE_VALUES, None)
+                    .unwrap()
+            }


_{reported by reviewdog 🐶}
[semgrep] Detected 'unsafe' usage, please audit for secure usage

Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage

Cc @thypon @kdenhartog

github-actions · 2025-08-07T20:09:40Z

src/flatbuffers/fb_network_filter_generated.rs

+                        flatbuffers::Vector<'a, flatbuffers::ForwardsUOffset<&'a str>>,
+                    >>(Engine::VT_SIMPLE_CLASS_RULES, None)
+                    .unwrap()
+            }


_{reported by reviewdog 🐶}
[semgrep] Detected 'unsafe' usage, please audit for secure usage

Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage

Cc @thypon @kdenhartog

github-actions · 2025-08-07T20:09:40Z

src/flatbuffers/fb_network_filter_generated.rs

+                        flatbuffers::Vector<'a, flatbuffers::ForwardsUOffset<&'a str>>,
+                    >>(Engine::VT_SIMPLE_ID_RULES, None)
+                    .unwrap()
+            }


_{reported by reviewdog 🐶}
[semgrep] Detected 'unsafe' usage, please audit for secure usage

Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage

Cc @thypon @kdenhartog

github-actions · 2025-08-07T20:09:40Z

src/flatbuffers/fb_network_filter_generated.rs

+                        flatbuffers::Vector<'a, flatbuffers::ForwardsUOffset<&'a str>>,
+                    >>(Engine::VT_MISC_GENERIC_SELECTORS, None)
+                    .unwrap()
+            }


_{reported by reviewdog 🐶}
[semgrep] Detected 'unsafe' usage, please audit for secure usage

Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage

Cc @thypon @kdenhartog

github-actions · 2025-08-07T20:09:40Z

src/flatbuffers/fb_network_filter_generated.rs

+                        flatbuffers::Vector<'a, flatbuffers::ForwardsUOffset<&'a str>>,
+                    >>(Engine::VT_COMPLEX_CLASS_RULES_INDEX, None)
+                    .unwrap()
+            }


_{reported by reviewdog 🐶}
[semgrep] Detected 'unsafe' usage, please audit for secure usage

Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage

Cc @thypon @kdenhartog

github-actions · 2025-08-07T20:09:40Z

src/flatbuffers/fb_network_filter_generated.rs

+                        flatbuffers::Vector<'a, flatbuffers::ForwardsUOffset<&'a str>>,
+                    >>(Engine::VT_COMPLEX_CLASS_RULES_VALUES, None)
+                    .unwrap()
+            }


_{reported by reviewdog 🐶}
[semgrep] Detected 'unsafe' usage, please audit for secure usage

Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage

Cc @thypon @kdenhartog

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.

Benchmark suite	Current: `f087a7b`	Previous: `4738d3f`	Ratio
`rule-match-browserlike/brave-list`	`2859316369` ns/iter (`± 26370025`)	`2252126465` ns/iter (`± 13369021`)	`1.27`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions · 2025-08-08T05:45:40Z

src/flatbuffers/fb_network_filter_generated.rs

+                        flatbuffers::Vector<'a, flatbuffers::ForwardsUOffset<NetworkFilterList>>,
+                    >>(Engine::VT_NETWORK_RULES, None)
+                    .unwrap()
+            }


_{reported by reviewdog 🐶}
[semgrep] Detected 'unsafe' usage, please audit for secure usage

Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage

Cc @thypon @kdenhartog

github-actions · 2025-08-08T05:45:40Z

src/flatbuffers/fb_network_filter_generated.rs

+                        None,
+                    )
+                    .unwrap()
+            }


_{reported by reviewdog 🐶}
[semgrep] Detected 'unsafe' usage, please audit for secure usage

Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage

Cc @thypon @kdenhartog

github-actions · 2025-08-08T05:45:40Z

src/flatbuffers/fb_network_filter_generated.rs

+                        None,
+                    )
+                    .unwrap()
+            }


_{reported by reviewdog 🐶}
[semgrep] Detected 'unsafe' usage, please audit for secure usage

Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage

Cc @thypon @kdenhartog

atuchin-m self-assigned this Aug 7, 2025

github-actions bot reviewed Aug 7, 2025

View reviewed changes

github-actions bot added the needs-security-review label Aug 7, 2025

github-actions bot assigned kdenhartog and thypon Aug 7, 2025

github-actions bot reviewed Aug 8, 2025

View reviewed changes

atuchin-m force-pushed the cosmetic-filter-fb-v3 branch from 11e5634 to 62d4b1f Compare August 8, 2025 05:43

github-actions bot reviewed Aug 8, 2025

View reviewed changes

atuchin-m force-pushed the cosmetic-filter-fb-v3 branch from 62d4b1f to bede9e2 Compare August 8, 2025 08:33

Cosmetic filters fb

f087a7b

atuchin-m force-pushed the cosmetic-filter-fb-v3 branch from bede9e2 to f087a7b Compare August 8, 2025 08:45

atuchin-m closed this Aug 12, 2025

Conversation

atuchin-m commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Rust Benchmark

Uh oh!

github-actions bot Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

github-actions bot Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

atuchin-m commented Aug 7, 2025 •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading