Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Remove default browser check (and set on launch).
Browse files Browse the repository at this point in the history
I believe this was causing a crash during end-to-end testing
  • Loading branch information
bsclifton committed Dec 7, 2018
1 parent 9b52daf commit f0be763
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions app/darwinInit.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,6 @@ if (process.platform === 'darwin') {
return false
}

const isDefaultBrowser = () => {
try {
const defaultProtocols = ['http', 'https']
return defaultProtocols.every(p => app.isDefaultProtocolClient(p))
} catch (e) {
return false
}
}

const installBraveCore = () => {
// get path to the bundled brave-core binary
const installerPath = getBraveCoreInstallerPath()
Expand Down Expand Up @@ -111,12 +102,6 @@ if (process.platform === 'darwin') {
// launch into freshly installed brave-core and append argument expected in:
// https://github.com/brave/brave-browser/issues/1545
let openCmd = `open -a "${installedPath}/${appName}/" --args --upgrade-from-muon`
if (isDefaultBrowser()) {
// if user has the Muon version of Brave as their default browser, let's
// ask the user to make Brave Core their new default. Passing this extra
// argument will prompt the user to ensure they agree with the choice
openCmd += ' --make-default-browser'
}
console.log('Launching brave-core')
execSync(openCmd)
} catch (e) {
Expand Down

0 comments on commit f0be763

Please sign in to comment.