Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expected txs in test #1153

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dangeross
Copy link
Collaborator

In test_address_transactions change the expected result. Looks like the mempool.space results are now block height ascending

@dangeross dangeross requested review from roeierez and JssDWt January 6, 2025 09:49
Copy link
Contributor

@JssDWt JssDWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really not be calling remote endpoints in unit tests. But for now this is good. LGTM.

@roeierez
Copy link
Member

roeierez commented Jan 6, 2025

In test_address_transactions change the expected result. Looks like the mempool.space results are now block height ascending

In their docs they mention that the sorting order is the newest first: https://mempool.space/docs/api/rest#get-address-transactions

@danielgranhao
Copy link
Contributor

danielgranhao commented Jan 6, 2025

I noticed the test failing as well. The order can change. Meaning that the test sometimes fails and other times succeeds. Maybe we can simply sort the result like shown here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants