Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not rely on uniFFI bindings #965

Draft
wants to merge 15 commits into
base: flutter_rust_bridge_v2
Choose a base branch
from
Draft

Do not rely on uniFFI bindings #965

wants to merge 15 commits into from

Conversation

erdemyerebasmaz
Copy link
Contributor

@erdemyerebasmaz erdemyerebasmaz commented May 7, 2024 •
edited
Loading

This PR builds on

and removes breez-sdk-bindings package & uniFFI bindings dependency of the Flutter plugin.

All related build steps are temporarily bundled under bootstrap recipe.

Changelist:

  • Generated Dart/Flutter bindings & FFI bindings
  • Exclude FFI bindings from static analysis
  • Disable checking for formatting changes on CI
    • Run "dart format -l 110 ."

TODO:

  • Unzip the framework files to their respective Android & iOS folders
  • Bundle notification package as part of non-uniFFI script
    • Only build uniffi bindings used on notification packages if necessary

@erdemyerebasmaz
Update flutter_rust_bridge to 2.0.0-dev.32
5c05346
@erdemyerebasmaz
Cleanup frb v1 files
a28df3f
@erdemyerebasmaz
Create flutter_rust_bridge.yaml configuration file
c9ad199 
Invoke flutter_rust_bridge_codegen without arguments
@erdemyerebasmaz
Generate bindings
66f1428 
Generate Dart bindings under lib/generated
@erdemyerebasmaz
Exclude generated files from static code analysis
8464897
@erdemyerebasmaz
Verify & initialize bindings on creating BreezSDK
8d8b445
@erdemyerebasmaz
Remove obsolete custom Exception, UnsupportedPlatform
b30cb8f 
Use UnsupportedError instead
@erdemyerebasmaz
Update flutter_rust_bridge to 2.0.0-dev.33 & generate bindings
6fa7806
@erdemyerebasmaz
Create bootstrap script that does not rely on uniffi bindings [WIP]
233079c 
Generate Dart/FLutter bindings & FFI bindings

TODO:
- Add symlinks
- Bundle notification package
  - Only build uniffi bindings used on notification packages if necessary
@erdemyerebasmaz erdemyerebasmaz requested a review from roeierez May 7, 2024 20:41
@erdemyerebasmaz erdemyerebasmaz changed the base branch from main to flutter_rust_bridge_v2 May 7, 2024 20:42
@erdemyerebasmaz erdemyerebasmaz force-pushed the flutter_rust_bridge_v2_no_uniffi_bindings branch from 0cca104 to dd0fc1b Compare May 7, 2024 22:11
@erdemyerebasmaz erdemyerebasmaz force-pushed the flutter_rust_bridge_v2 branch from 6fa7806 to c90797d Compare May 18, 2024 23:00
@erdemyerebasmaz erdemyerebasmaz force-pushed the flutter_rust_bridge_v2 branch 2 times, most recently from 9a7b4eb to 797375d Compare May 27, 2024 15:45
@erdemyerebasmaz erdemyerebasmaz mentioned this pull request May 27, 2024
Open
2 tasks
@erdemyerebasmaz erdemyerebasmaz changed the title [frb] Do not rely on uniFFI bindings Do not rely on uniFFI bindings May 28, 2024
@erdemyerebasmaz erdemyerebasmaz force-pushed the flutter_rust_bridge_v2 branch from dd27d88 to 4b31137 Compare June 24, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeierez roeierez Awaiting requested review from roeierez

Assignees
No one assigned
Labels
flutter_rust_bridge low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erdemyerebasmaz