Update & optimize CI workflow for App Store Connect compatibility #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[MT] IDEDistribution: Command line name "app-store" is deprecated. Use "app-store-connect" instead.
- Added a Run Script build phase to strip bitcode from Tor.framework - Resolves App Store validation error where Tor executable contained bitcode - Apple no longer accepts bitcode in app submissions since Xcode 14 - This change maintains compatibility with our required Tor framework version
There was a problem hiding this comment.
Pull Request Overview
This PR updates and optimizes the CI workflow to support App Store Connect compatibility by stripping bitcode and modernizing the build steps.
- Update CI workflow to remove bitcode from Tor.framework and update deprecated methods
- Upgrade actions versions and incorporate caching for Go and Flutter setup
- Add parallel disk cleanup steps and improve repository checkout and build stages
Files not reviewed (3)
- .github/scripts/export-options.plist: Language not supported
- .github/scripts/sign.sh: Language not supported
- ios/Runner.xcodeproj/project.pbxproj: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple no longer accepts bitcode in app submissions. This PR addresses this issue by stripping bitcode from
Tor.framework.It has several other improvements, such as updating deprecated methods & bringing the build steps in line with our new & updated CI workflows, and using GitHub actions w/ caching mechanism to save time on setting up Go, Flutter & checking-out SDK repository.