Skip to content

cli improvements #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025
Merged

cli improvements #51

merged 4 commits into from
Apr 28, 2025

Conversation

JssDWt
Copy link
Collaborator

@JssDWt JssDWt commented Apr 25, 2025

  • Set a default for the internal grpc address in the cli
  • Return more information about pending swaps, like
    • creation time
    • outputs
    • payment attempts
    • whether it's locked

@JssDWt JssDWt requested review from yaslama, roeierez and Copilot April 25, 2025 11:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the CLI and swap status reporting by setting a default internal gRPC address and by including additional pending swap details (creation time, outputs, payment attempts, and lock status).

  • Renames error types and updates functions for retrieving payment attempts and swap locks.
  • Updates proto definitions, internal server mappings, and test assertions to accommodate the new swap details.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
swapd/src/swap/swap_repository.rs Renamed error enum and added new structs to support payment details.
swapd/src/postgresql/swap_repository.rs Adjusted queries and function signatures for payment attempts.
swapd/src/postgresql/chain_repository.rs Updated SQL queries and mapping to return enriched TXO data.
swapd/src/internal_server.rs Extended GetSwapResponse with additional swap information.
swapd/src/chain/types.rs, repository.rs, mod.rs Introduced new types and re-exports for swap spends.
swapd/proto/swap_internal/swap_internal.proto Updated proto messages to carry new swap-related fields.
swap-cli/src/main.rs Set default internal gRPC URI.
itest tests Added/modified tests to validate the new swap details.

@JssDWt JssDWt merged commit 30cc917 into main Apr 28, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant