Skip to content

put route hints in email #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

JssDWt
Copy link
Collaborator

@JssDWt JssDWt commented Apr 8, 2025

Make it a little faster to diagnose issues by logging the route hints in sent emails

@JssDWt JssDWt requested a review from Copilot April 8, 2025 14:31
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (4)

src/htlc_manager.rs:655

  • Ensure that the return type of 'route_hints()' matches the expected 'Vec' type for the notification request.
+                    hints: trampoline.invoice.route_hints(),

src/email.rs:30

  • [nitpick] The label 'Route hint' might be ambiguous; consider clarifying the output label or adding contextual information to improve readability in diagnostic emails.
format!("<tr><td>Route hint {}: {}, {}</td></tr>", i, hint.src_node_id, scid_to_string(hint.short_channel_id),)

src/email.rs:46

  • Consider adding tests to cover cases where no route hints are provided, ensuring the email HTML renders correctly without hints.
hints.join("")

src/email.rs:62

  • Double-check that the bitwise operations correctly extract all components of the SCID as expected for all supported formats.
format!("{}x{}x{}", scid >> 40, (scid >> 16) & 0xFFFFFF, scid & 0xFFFF)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant