-
Notifications
You must be signed in to change notification settings - Fork 7
Add certificates checks #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add checks of validity of the certificates in the near future (1 month from now). Add checks of the certificates declared usage.
|
@dolmen thanks for your PR. I am not yet convinced, that this test is actually helpful. This repo has a recurring job (runs weekly, https://github.com/breml/rootcerts/blob/master/.github/workflows/update.yml#L21), that checks, if there has been a change in the upstream certificates, that are embedded, which are served by the Mozilla Foundation. If the certificates provided by the Mozilla Foundation are no longer up to date (or do contain certificates, that are out of validity), then the wider ecco system does have a serious problem anyway with all the Firefox, Thunderbrid, etc. installations in the wild. We have to trust the Mozilla Foundation to do the right thing. If we don't, the validity is our least problem. I made sure, that this GH action is kept active and it has run for the past 4 years. Do I miss something? Where exactly do you see the additional value of this test? |
|
|
I looked at this PR and I am fine with merging it. |
|
@breml I've accepted and pushed your changes. |
breml
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@dolmen The check now fails in https://github.com/breml/rootcerts/actions/runs/14425557364/job/40453882801, but the certificate is still valid until May. Can you please have a look? |
Add Go tests in package
embeddedto check:GH Actions workflow is updated to run the tests.
Note: I had written an earlier version of those checks for
gocertifiin certifi/gocertifi#28.