Skip to content

Fix truncation of last character of VIN by modifying decode_encoded_string() #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+2 −1
Open

Fix truncation of last character of VIN by modifying decode_encoded_string() #276

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
090b66a
Fix truncation of last character of VIN number by modifying decode_en…
gwillgues May 4, 2024
05514fc
Add environment variable logging verbosity support via DEBUG env var
gwillgues May 4, 2024
a10a12c
Revert "Fix truncation of last character of VIN number by modifying d…
gwillgues May 4, 2024
c67bbf4
Revert "Revert "Fix truncation of last character of VIN number by mod…
gwillgues May 4, 2024
efe417a
Revert "Add environment variable logging verbosity support via DEBUG …
gwillgues May 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion obd/decoders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,8 @@ def decode_encoded_string(messages, length):
# Encoded strings come in bundles of messages with leading null values to
# pad out the string to the next full message size. We strip off the
# leading null characters here and return the resulting string.
return d.strip().strip(b'\x00' b'\x01' b'\x02' b'\\x00' b'\\x01' b'\\x02')
decoded_string = d.strip().replace(b'\x00', b'').replace(b'\x01', b'').replace(b'\x02', b'').replace(b'\\x00', b'').replace(b'\\x01', b'').replace(b'\\x02', b'')
return decoded_string


def cvn(messages):
Expand Down