Fix single precision mode #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was failing in single precision mode. Now using type that is set to the floating point precision preference
The current regex version replaces `10.` with `10.f` in `#include "name_10.h"`
Our regex currently replaces `_10.h` with `_10.fh`. This also affects `var12.metho()` type variables and needs to be fixed! But for now this workaround just ignores `#include` lines, where header files might be named like this.
Sets the tolerance depending on floating point precision, else tests might fail due to precision in single precision mode.
Else tests fail in single precision mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #234
Remaining lower priority single precision issues are collected in #264