-
Notifications
You must be signed in to change notification settings - Fork 44
Allow ruby version 3.4 in gemspec #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like a quoting change between 3.3 and 3.4 leads to change in output, which causes one failure. Specifically: This is generated under 3.3 and earlier... But under 3.4... (Note the change in ` to ' there) Not sure how critical that format aspect is, or full context on that spec. |
|
Hey @mjankowski! I made an attempt to fix the failing test, feel free to cherrypick my commit a7ebab0 here |
|
Thanks -- going to stand by on maintainer feedback re: desired path here, but will grab your commit if we're fine w/ that level of precision (again I dont fully understand context here). Seems like it more or less preserves intentions while being more flexible on apparently-version-specific output format. |
|
Hey @briandunn!! First of all, thanks for maintaining this gem, it's awesome! Are you ok with the approach taken here?
|
|
Oh yeah, also - separately from this formatting issue ... I can confirm that actually using/running flatware on 3.4.1 (with this PR branch allowing bundle) appears to be totally fine! My suite runs are as parallel as they've ever been. |
|
Updated to add one of those commits which also fixes the failure. Should be passing now. @briandunn whenever you are back from holiday let me know if this makes sense or you'd prefer some other approach. |
briandunn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! Loosening the assertion was exactly what I had in mind when I saw the initial failures. nice.
Resolves #103