Force numeric-string return type in BigDecimal::__toString() and BigInteger::__toString() #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nteger::__toString()
Looks reasonable. |
|
Thank you, @vudaltsov! |
|
Released as 0.13.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #89.
@return numeric-stringcannot be added toBigRational, because'10/20'is not a numeric string. So I addednumeric-stringtoBigDecimalandBigIntegerclasses only. This does not break LSP, because methods return types are covariant andnumeric-string <: string.I forced types via
@varannotation, otherwise the refactoring would be huge and still in most places we will have to force type, for example where$signis concatenated with$value.