This repository was archived by the owner on May 27, 2025. It is now read-only.
Skinappchanges #380
Open
Skinappchanges #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orobles-ooyala @AlinaVoronkovaEpam can you review this one? Would prefer if you do so you are aware of the changes. |
DmitriiMaslov
requested review from
AlinaVoronkovaEpam,
SergeyBicarte,
bychkovdmitry,
cacel,
ipadilla4 and
isheftel-ooyala
isheftel-ooyala
suggested changes
Nov 2, 2018
ContentProtectionSampleApp/app/src/main/java/com/ooyala/sample/players/CustomActivity.java
Outdated
Show resolved
Hide resolved
OoyalaSkinSampleApp/app/src/main/java/com/ooyala/sample/players/GeoBlockingActivity.java
Show resolved
Hide resolved
OoyalaSkinSampleApp/app/src/main/java/com/ooyala/sample/players/GeoBlockingActivity.java
Show resolved
Hide resolved
OoyalaSkinSampleApp/app/src/main/res/layout/embed_pcode_layout.xml
Outdated
Show resolved
Hide resolved
isheftel-ooyala
suggested changes
Nov 2, 2018
ContentProtectionSampleApp/app/src/main/java/com/ooyala/sample/players/CustomActivity.java
Outdated
Show resolved
Hide resolved
OoyalaSkinSampleApp/app/src/main/res/layout/embed_pcode_layout.xml
Outdated
Show resolved
Hide resolved
|
Implemented review comments. Please review. |
|
LGTM |
isheftel-ooyala
approved these changes
Nov 2, 2018
SergeyBicarte
suggested changes
Nov 6, 2018
Merged
|
Please, make branch from https://github.com/ooyala/android-sample-apps repo, do not fork it to your own https://github.com/sndy35/android-sample-apps. Also, does it need to be in "candidate" branch, may be "dev" is enough right now? |
SergeyBicarte
force-pushed
the
candidate
branch
from
936c192 to
b5648c1
Compare
loginov-rocks
requested review from
SergeyBicarte
and removed request for
brol1dev and
bychkovdmitry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have modified custom activity to. accept apikey and secret as parameters