Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AN-224 Fix vmCostPerHour being 10x what it should be #7576

Merged
merged 1 commit into from
Oct 28, 2024
Merged

AN-224 Fix vmCostPerHour being 10x what it should be #7576

merged 1 commit into from
Oct 28, 2024

Conversation

jgainerdewar
Copy link
Collaborator

@jgainerdewar jgainerdewar commented Oct 25, 2024 •
edited
Loading

Description

While it's true that nano units are nine-y, when doing exponential math stuff we need to remember that the 10 contributes one order of magnitude.

Release Notes Confirmation

CHANGELOG.md

  • I updated CHANGELOG.md in this PR
  • I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

  • I added a suggested release notes entry in this Jira ticket
  • I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

@jgainerdewar jgainerdewar requested a review from a team as a code owner October 25, 2024 21:07
aednichols
aednichols approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@aednichols aednichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@jgainerdewar jgainerdewar merged commit 32685d1 into develop Oct 28, 2024
38 of 39 checks passed
@jgainerdewar jgainerdewar deleted the jd_AN-224_costx10 branch October 28, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salonishah11 salonishah11 salonishah11 approved these changes

@aednichols aednichols aednichols approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgainerdewar @aednichols @salonishah11