Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AN-184 Remove unused Batch restrict-metadata-access config #7577

Merged
merged 1 commit into from
Nov 2, 2024
Merged

AN-184 Remove unused Batch restrict-metadata-access config #7577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...src/main/scala/cromwell/backend/google/batch/models/GcpBatchConfigurationAttributes.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ case class GcpBatchConfigurationAttributes(
project: String,
computeServiceAccount: String,
auths: GcpBatchAuths,
restrictMetadataAccess: Boolean,
dockerhubToken: String,
enableFuse: Boolean,
executionBucket: String,
Expand Down Expand Up @@ -327,7 +326,6 @@ object GcpBatchConfigurationAttributes extends GcpBatchReferenceFilesMappingOper
project = project,
computeServiceAccount = computeServiceAccount,
auths = GcpBatchAuths(batchAuth, gcsAuth),
restrictMetadataAccess = restrictMetadata,
dockerhubToken = dockerhubToken,
enableFuse = enableFuse,
executionBucket = bucket,
Expand Down
1 change: 0 additions & 1 deletion ...scala/cromwell/backend/google/batch/actors/GcpBatchBackendLifecycleActorFactorySpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class GcpBatchBackendLifecycleActorFactorySpec extends AnyFlatSpecLike with Matc
project = "project",
computeServiceAccount = "computeServiceAccount",
auths = null,
restrictMetadataAccess = true,
dockerhubToken = "test",
enableFuse = true,
executionBucket = "executionBucket",
Expand Down
1 change: 0 additions & 1 deletion ...cala/cromwell/backend/google/batch/callcaching/BatchBackendCacheHitCopyingActorSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,6 @@ class BatchBackendCacheHitCopyingActorSpec
project = null,
computeServiceAccount = null,
auths = null,
restrictMetadataAccess = false,
dockerhubToken = null,
enableFuse = false,
executionBucket = null,
Expand Down
10 changes: 0 additions & 10 deletions ...test/scala/cromwell/backend/google/batch/models/GcpBatchConfigurationAttributesSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ class GcpBatchConfigurationAttributesSpec
gcpBatchAttributes.executionBucket should be("gs://myBucket")
gcpBatchAttributes.maxPollingInterval should be(600)
gcpBatchAttributes.computeServiceAccount should be("default")
gcpBatchAttributes.restrictMetadataAccess should be(false)
gcpBatchAttributes.referenceFileToDiskImageMappingOpt.isEmpty should be(true)
gcpBatchAttributes.logsPolicy should be(GcpBatchLogsPolicy.CloudLogging)
}
Expand Down Expand Up @@ -112,15 +111,6 @@ class GcpBatchConfigurationAttributesSpec
gcpBatchAttributes.computeServiceAccount should be("testing")
}

it should "parse restrict-metadata-access" in {

val backendConfig = ConfigFactory.parseString(configString(batch = "restrict-metadata-access = true"))

val gcpBatchAttributes = GcpBatchConfigurationAttributes(googleConfig, backendConfig, "batch")
gcpBatchAttributes.restrictMetadataAccess should be(true)

}

it should "parse localization-attempts" in {

val backendConfig = ConfigFactory.parseString(configString(batch = "localization-attempts = 31380"))
Expand Down
Loading