bump sonar scanner version, fix includedModules #2793
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
denniscunningham
left a comment
denniscunningham
left a comment
There was a problem hiding this comment.
Thx Tom.
Just one question.
| </profiles> | ||
| <pluginGroups> | ||
| <pluginGroup> | ||
| org.sonarsource.scanner.maven |
Author
There was a problem hiding this comment.
org.sonarsource.scanner.maven is the SonarQube scanner that is integrates into a Maven build and runs on Java classfiles after compilation.
Author
|
@denniscunningham I moved this back to draft to make a couple more edits. We will need to talk more about the CircleCI part too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the sonar scanner version and fixes a typo in the list of includedModules. This enables makes it so all the code is scanned in one scan:
cd pepper-apis mvn sonar:sonarThis could be set up in CircleCI as a parallel workflow. Or if that's not fast enough, I can set up a second sonarcloud project and we can break it into two scans.
There must be a one-to-one correspondence between scan runs in CI and sonar projects. Each scan run on the same project key replaces the prior scan results.