Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging for legacy private dataset access #13

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

snwessel
Copy link
Member

Asana

Adding logging to confirm private datasets are only being read from breadbox after their migration. This makes use of the existing data_access logging which writes to a access.log file. These logs will be written as their own unique "type" so they'll be easy to search for:

{"timestamp": "2024-07-22T13:04:39.565780", "type": "legacy-private-dataset-access", "endpoint": "data_explorer_2.plot_dimensions", "function": "compute_dimension", "dataset": "d6196b18-b1f8-4646-a182-9c8c29950fbf", "user": "[email protected]"}

I didn't want to be super repetitive about updating the codebase to check "if it's a private dataset, write a log", so I just updated a couple of low-level frequently used functions like get_dataset_label to log whenever they're called with a non-breadbox private dataset.

@snwessel snwessel requested a review from pgm July 23, 2024 19:03
Copy link
Contributor

@pgm pgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snwessel snwessel merged commit 219b5e0 into master Jul 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants