Add logging for legacy private dataset access #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana
Adding logging to confirm private datasets are only being read from breadbox after their migration. This makes use of the existing
data_access
logging which writes to aaccess.log
file. These logs will be written as their own unique "type" so they'll be easy to search for:I didn't want to be super repetitive about updating the codebase to check "if it's a private dataset, write a log", so I just updated a couple of low-level frequently used functions like
get_dataset_label
to log whenever they're called with a non-breadbox private dataset.