Delete genomic associations and old top codependencies #565
Conversation
|
I left this as a draft for now because it ended up touching A LOT more than I expected. It might be best to merge this in after 26q1 to reduce risk. @snwessel let me know if you'd prefer I merge this sooner |
|
So exciting! |
snwessel
left a comment
snwessel
left a comment
There was a problem hiding this comment.
Looks great!
And wow that's quite the number of changes! Glad to see this being removed
I agree that it might make sense to wait until after a release branch is made to merge this in. Even if that means waiting a few weeks, I doubt you'll get many merge conflicts since we don't ever really touch this feature.
|
|
||
|
|
||
| def determine_compound_experiment_and_dataset(compound_experiment_and_datasets): | ||
| # DEPRECATED: this method will not work with breadbox datasets. Calls to it should be replaced. |
There was a problem hiding this comment.
🎉 I'm so excited to see this function isn't being used anymore! A year or so ago, this had been used to determine which datasets were displayed for most of the compound page, and it was referenced all over the place. Feels like a nice milestone 😁
Let's make it a point not to commit mock JSON files that are 100,000+ lines long ever again 😂 |
alimourey
changed the title
The goal of these changes were to delete all portal-backend and frontend genomic associations (aka Celfie) code. I discovered legacy Constellation code that was only left behind to support Celfie, and so I deleted that as well.