-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JN-477] admin help for export #481
Conversation
number of columns to be exported exceeds 16K. In order to have data be compliant, double-quotes will | ||
be replaced by single quotes, and any values including |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't really necessary to replace double quotes with single quotes. It's unlikely that the meaning of any responses will be different, but I have to confess to being a little uneasy about any modification of responses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right that they can be escaped, but other applications handling of escaped quotes in csv files varies enough that it was decided for Pepper that this strategy would result in less user issues (and they can always grab the .xlsx format if quote fidelity is important)
<ExportDataControl studyEnvContext={mockStudyEnvContext()} show={true} setShow={() => {}}/>) | ||
render(RoutedComponent) | ||
userEvent.click(screen.getByText('help page')) | ||
waitFor(() => expect(screen.getByText('Participant List Export Info')).toBeInTheDocument()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. I didn't expect to not need any code to recognize the content opened in a new window.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing that the headless browser just ignores the target="_blank" and opens it in the same window
Signed-off-by: Tom Conner <[email protected]>
This adds basic help docs (copied over from Pepper) for the download capability. The existence of help docs within our app is probably temporary. Long-term, we'll want to use ZenDesk or some other solution that lets non-engineers write/edit the docs. I'll put in a request to comms to see about getting that set up. In the meantime, this will give us a place to park user-visible documentation. Also, having it be in-app makes the release/review process much simpler -- the docs get auto-released with the features, rather than having to be reviewed and released separately.
TO TEST: