Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JN-372, DSEC-659 include sonar in Java CI #483

Merged
merged 86 commits into from
Jul 28, 2023
Merged

JN-372, DSEC-659 include sonar in Java CI #483

merged 86 commits into from
Jul 28, 2023

Conversation

TomConner
Copy link
Contributor

@TomConner TomConner commented Jul 20, 2023 •
edited
Loading

Create new Sonar workflow to scan Java code in

and TypeScript code in

Because Sonar's Java and TypeScript scanning want to run separately, there are four separate SonarCloud projects that all correspond to this one GitHub repo.

@TomConner TomConner requested a review from devonbush July 20, 2023 14:53
@TomConner TomConner changed the title include sonar in Java CI DSEC-659 include sonar in Java CI Jul 20, 2023
@TomConner TomConner changed the title DSEC-659 include sonar in Java CI JN-372, DSEC-659 include sonar in Java CI Jul 20, 2023
@devonbush devonbush requested a review from breilly2 July 20, 2023 14:58
@TomConner TomConner marked this pull request as draft July 20, 2023 15:13
@TomConner
Copy link
Contributor Author

I'm reworking to separate the different subproject scans so that SonarQube is happy.

@github-actions
Copy link

SonarCloud analyzed branch: DSEC-659/

1 similar comment
@github-actions
Copy link

SonarCloud analyzed branch: DSEC-659/

@github-actions
Copy link

SonarCloud analyzed ui-participant on DSEC-659/

@github-actions
Copy link

SonarCloud analyzed ui-admin on DSEC-659/

@TomConner TomConner marked this pull request as ready for review July 28, 2023 05:05
@github-actions
Copy link

SonarCloud analyzed ui-participant on DSEC-659

@github-actions
Copy link

SonarCloud analyzed ui-admin on DSEC-659

@TomConner TomConner enabled auto-merge July 28, 2023 05:33
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

MatthewBemis
MatthewBemis approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@MatthewBemis MatthewBemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍 I just have one question about the workflow trigger.

.github/workflows/sonar.yaml
workflow_dispatch:
push:
branches:
- master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be triggered by pushes to the development branch instead? development is ultimately what ends up going to production, as we don't use a master or main branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Good catch.

@TomConner TomConner added this pull request to the merge queue Jul 28, 2023
Merged via the queue into development with commit 5202702 Jul 28, 2023
9 of 12 checks passed
@TomConner TomConner deleted the DSEC-659 branch July 28, 2023 15:51
@github-actions
Copy link

SonarCloud analyzed ui-core on DSEC-659

@github-actions
Copy link

SonarCloud analyzed ui-participant on DSEC-659

@github-actions
Copy link

SonarCloud analyzed ui-admin on DSEC-659

@TomConner TomConner restored the DSEC-659 branch July 28, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewBemis MatthewBemis MatthewBemis approved these changes

@devonbush devonbush devonbush approved these changes

@breilly2 breilly2 Awaiting requested review from breilly2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomConner @devonbush @MatthewBemis