Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JN-479: adding download of mailing list #492

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

devonbush
Copy link
Collaborator

@devonbush devonbush commented Aug 2, 2023

Clicking the "download" link above the mailing list view now downloads the selected members of the mailing list as a CSV.

image

This also has a couple of related general changes:

  1. Upgraded our versions of testing libraries -- this solves some "updates happening outside of 'act'" warnings we were getting in tests", and required tweaking some other tests to better handle user events
  2. Swapped the "send email" button on the participant list with our button component that properly handles disabled tooltips.

TO TEST:

  1. go to https://localhost:3000/ourhealth/env/sandbox/mailingList
  2. select some/all entries
  3. click "download"
  4. confirm a csv file with the selected participants is downloaded

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

@devonbush devonbush added this pull request to the merge queue Aug 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 4, 2023
@devonbush devonbush added this pull request to the merge queue Aug 4, 2023
Merged via the queue into development with commit 5bdce51 Aug 4, 2023
6 of 7 checks passed
@devonbush devonbush deleted the db-download-mailing-list branch August 4, 2023 14:33
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants