-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a docker image to be used for creating Terra cloud environment #421
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great idea. I had one question about including gsutil.
Another question - are there other fundamental packages that are missing? What about things like bwa-mem
/ bwa-mem2
/ minigraph
/ miniasm
?
apt-get -qqy clean && \ | ||
rm -rf /tmp/* \ | ||
/var/tmp/* \ | ||
/var/cache/apt/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about other common cloud utilities, such as gsutil
? Does the terra base image include that?
FYI, this is how I usually install it so crcmod works and parallel uploads/downloads are fast:
# install gsutil
RUN apt-get --allow-releaseinfo-change update
RUN apt install -y curl git-lfs time datamash
RUN curl https://sdk.cloud.google.com | bash
# Setup crcmodc for gsutil:
RUN apt-get install -y gcc python3-dev python3-setuptools && \
pip3 uninstall -y crcmod && \
pip3 install --no-cache-dir -U crcmod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you're right. The base image I depend on handles the google cloud stuff.
I don't want to mess with that, other than that line which updates the google cloud cli.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, sounds good. Feel free to merge.
Thanks for the review, Jonn. |
No description provided.