CORE-707: add index for WORKSPACE_SETTINGS table #3502
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidangb
commented
Oct 23, 2025
| ctx, | ||
| startDateOpt, | ||
| endDateOpt | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
scalafmt; not sure why it complained in this PR.
davidangb
commented
Oct 23, 2025
| val subList = | ||
| Await.result(submissionsService.listSubmissions(testData.wsName, testContext, Option.empty, Option.empty), | ||
| Duration.Inf | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
scalafmt; not sure why it complained in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CORE-707
Some swatomation tests are flaky because workspace-creation fails with a lock-wait timeout creating the
CompactDataTablesworkspace setting for that workspace.I looked at various SQL queries involved in listing and applying settings, and they will benefit from a table index. The index should reduce how much of the table needs to be locked and reduce how long a lock needs to be held. (the insert statement will not benefit from this index; only select, update, and delete will).