[TOAZ-363] Allow UAMI accounts to be added to service admin whitelist #1466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UAMI accounts will not have oidc email field populated through token, need to be dynamically built Needed if Thurloe is running as an UAMI and needs service account admin whitelist
dvoet
suggested changes
Jun 28, 2024
src/main/scala/org/broadinstitute/dsde/workbench/sam/api/StandardSamUserDirectives.scala
Show resolved
Hide resolved
src/main/scala/org/broadinstitute/dsde/workbench/sam/api/StandardSamUserDirectives.scala
Outdated
Show resolved
Hide resolved
Swapped boolean logic to allow if either condition is true as opposed to reject if both conditions are false Added helper function to verify email oidcHeader is empty to clean up logic in route slightly and remove edge case of [email protected] being a potentially valid value in serviceAccountAdmin configuration
|
dvoet
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: (https://broadworkbench.atlassian.net/browse/TOAZ-363)
What:
UAMI accounts do not have OIDC_email field populated through accesstoken, need to be dynamically built from b2cid
Why:
Needed if Thurloe is running as a user assigned managed identity on azure and needs service account admin whitelist
How:
Additional check in service account admin whitelist based UAMI email
PR checklist