Update CI actions + widen node range to see what's what #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kategengler
force-pushed
the
kg-get-ci-running
branch
from
cd3eaa6 to
3d47fe1
Compare
This reverts commit 8401494.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts unreleased #486 from 2021 -- without those changes tests pass on newer node.
My first thought was to do the minimal changes possible to get the security patches in and release a patch or minor of broccoli. Unfortunately, broccoli is a direct dependency of ember-cli and any patch or minor would propagate back to even those using ember-cli 3.11.
sanev5 drops support for Node 8 but Node 8 was supported by ember-cli through ember-cli 3.16, so any release of broccoli with the updated sane will need to be a major.Current status: Mac OS jobs will fail because those earlier nodes are not available on latest macos. Node 22 fails due to the esm package which is used only via the broccoli cli. Afaict, the cli is pretty much unused and could be dropped in a major.