Add isContainedWithin function for ShadowRoots #1374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `el.contains(e)` would return `false` if `e` was inside ShadowRoots. If `el.contains(e)` returns `false`, `isContainedWithin(e, el)` will instead check `e`'s root, and the root's root, and so on, until either `contains` returns `true` or the top of the tree is reached.
|
Regarding the other two instances of Surfingkeys/content_scripts/utils.js Line 279 in 4a274fe Surfingkeys/content_scripts/utils.js Line 220 in 4a274fe presumably we could run into the same issue with ShadowRoots, but I don't know if I've encountered it in the wild yet, so I thought it might be best to keep the change smaller for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
el.contains(e)would returnfalseifewas inside ShadowRoots. Ifel.contains(e)returnsfalse,isContainedWithin(e, el)will instead checke's root, and the root's root, and so on, until eithercontainsreturnstrueor the top of the tree is reached.