Fix: Overflow hints behaviour (#2304) #2305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes brookhong#2304 - Now the hints host get the height and the width of the visible user's viewport (instead of the only height before that) - Width and height are now taken without considering the scrollbar and without floating point values. Isues: brookhong#2304, brookhong#2294
|
Is it possible to add a simple page to reproduce the issue you're trying to fix into the folder https://github.com/brookhong/Surfingkeys/tree/master/tests/data? I just got an idea to maintain the test data set so that we can avoid regression in future. The test file should be named |
Evilur
changed the title
|
I didn't fully understand what was required of me, since such a test had already been written. So I added a test for ‘Overflow-Y’ (dd89b78): Overflow-Y Examples |
Default behaviour
With fix
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2304
pointer-events: none)