feat: fallback to scrolling the document when the focused element is not scrollable #2362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional scrollFallback setting that enables automatic fallback to document-level scrolling when the focused element cannot scroll in the requested direction. Defaults to false to preserve existing behavior. - Add canScrollInDirection helper to detect scroll capability - Use Map for efficient scroll type to direction mapping - Only fallback when setting is enabled and element can't scroll
twio142
force-pushed
the
feat/fallback-scolling
branch
from
3cbeaf9 to
66169b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option
settings.scrollFallbackthat enables automatic fallback to document-level scrolling when the focused element cannot scroll in the requested direction. Defaults to false to preserve existing behavior.canScrollInDirectionhelper to detect scroll capabilityUseful when, for example, you're browsing a GitHub page with a lot of code blocks that are only horizontally scrollable, while keep scrolling the whole page down.