Vim mode experimental #264
Conversation
The keybindings are hardcoded for now, but this is going to change.
Added moveTabLeft and moveTabRight functions, which take a tab ID and try to move the tab as far right or left in the tabOrder as possible. Added previouslyVisitedTab function that switches to the previously selected tab.
with activating input boxes using link hinting.
…m-mode-experimental
In Firefox 63 an old syntax for Marionette commands was deprecated. Updating mostly just meant prepending `WebDriver` to existing commands. This should fix most problems in browsh-org#232
Vim mode still needs a lot more tests
…to key combinations only working after a certain number of key strokes.
|
Tests! Wow, this is so great to see you doing this :) If you can get all the main functionality of Vim Mode tested then we can merge it into master. |
|
would like to restruct the integration test to have less restart of
firefox, or having a deterministic way of cleanup/init everything. right
now not easy to get a pass with 23 tests in tty.
…On Sun, Jun 16, 2019, 10:36 PM Thomas Buckley-Houston < ***@***.***> wrote:
Tests! Wow, this is so great to see you doing this :) If you can get all
the main functionality of Vim Mode tested then we can merge it into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#264?email_source=notifications&email_token=AAAS6LPZMO6D2S7SDOCZZF3P24PFTA5CNFSM4HYQKPT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2CUUI#issuecomment-502540881>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAS6LIXA6TCSI7YAF3S2BLP24PFTANCNFSM4HYQKPTQ>
.
|
|
Exactly. That's why we have the flake retries set to 3, I think that could actually be set higher. I actually recently spent a lot of time looking into it. I'm fairly confident that most of the failures are real, as in those are actual real bugs in Browsh being surfaced by the tests. This means that the test runner itself is actually probably pretty reliable. So the best thing would be to actually fix the bugs in Browsh (or just increase the flake retry attempts to 6! haha). For example one of the most annoying bugs is where text doesn't get rendered, that's been a problem for months that you sometimes see when using Browsh yourself. So once bugs like that get fixed the tests will become much more reliable. |
| @@ -210,15 +212,32 @@ export default class extends utils.mixins(CommonMixin, CommandsMixin) { | |||
| let target = document.querySelector("body"); | |||
| let observer = new MutationObserver(mutations => { | |||
| mutations.forEach(mutation => { | |||
| if (!target) { | |||
There was a problem hiding this comment.
Interesting! Can you tell me more about this bit?
There was a problem hiding this comment.
I see type error from logs, makes me believe the body node some times doesn't exist at that time.
tombh
force-pushed
the
vim-mode-experimental
branch
from
0c0b907 to
b2ade39
Compare
|
Could you rebase the |
my changes,
|
|
I started to use browsh and I love the idea. But this is the key feaure missing for me since the default mappings wont all work inside my Tmux. So, any news on when this will be released? Or is there a way I can try this version (with the Vim mappins) by compiling from source? P.S: Thanks for creating and mantaining this great project 😃 |
|
@dvd42 You can always just try installing Vim Vixen yourself with Browsh's Firefox in GUI mode (so you can actually install normal Firefox extensions): https://www.brow.sh/docs/extensions/ @ed2k Again apologies for the delay. I just don't have the mental bandwidth at the moment to digest the significance of this work :'( |
|
@tombh, thanks for the swift reply. I tried this approach and it doesnt seem to work. The new keybindings dont do anything. I tried it both with Vim vixen and Vimium-ff. Any ideas? |
test to see how this travis works