feat: Ewm 481 browser group #898
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…481-browser-group # Conflicts: # lib/feature/browser_v2/data/groups/browser_group.dart # lib/feature/browser_v2/data/groups/browser_group.freezed.dart # lib/feature/browser_v2/data/groups/browser_group.g.dart # lib/feature/browser_v2/domain/service/storages/browser_groups_storage_service.dart # lib/feature/browser_v2/managers/groups_manager.dart
# Conflicts: # lib/di/di.config.dart # lib/feature/browser_v2/domain/service/browser_service.dart # lib/feature/browser_v2/screens/main/browser_main_screen_model.dart # lib/feature/browser_v2/screens/main/browser_main_screen_wm.dart # lib/feature/browser_v2/screens/main/delegates/tab_menu_delegate.dart # packages/ui_components_lib/lib/components/common/container/primary_shaped_container_column.dart
knightsforce
changed the title
Odrin
reviewed
May 30, 2025
| } | ||
| } | ||
|
|
||
| extension BrowserGroupExt on BrowserGroup { |
There was a problem hiding this comment.
tabsCountText нужен при рендере.
There was a problem hiding this comment.
В плане почему не просто в тело класса?
There was a problem hiding this comment.
Если геттер поместить в BrowserGroup - будет проблема с генерацией.
There was a problem hiding this comment.
Там надо только приватный конструктор добавить и будет работать:
const BrowserGroup._();
Odrin
approved these changes
May 30, 2025
lib/feature/browser_v2/screens/main/browser_main_screen_wm.dart
Outdated
Show resolved
Hide resolved
...eature/browser_v2/screens/main/widgets/tabs/tabs_list/widgets/header/tab_list_header_wm.dart
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change