feat(EWM-519): tycho staking #903
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knightsforce
reviewed
Jun 9, 2025
| @@ -49,7 +50,7 @@ class GasPriceService { | |||
| (json) => AbiParam.fromJson(json as Map<String, dynamic>), | |||
| ) | |||
| .toList(), | |||
| boc: params[21]!, // 20 for masterchain | |||
| boc: params[type.paramsKey]!, | |||
There was a problem hiding this comment.
Мы в этом месте гарантируем что не null?
Или есть вероятность что может крашнуть?
knightsforce
reviewed
Jun 9, 2025
| final info = _nekotonRepository.currentTransport.stakeInformation; | ||
| if (info == null) return StakingFees.empty(); | ||
|
|
||
| if (_networkType == 'tycho') { |
There was a problem hiding this comment.
Нам нужно где-то положить в константы название сетей для таких случаев.
Odrin
force-pushed
the
feat/EWM-519_tycho-staking
branch
from
93cb3ab to
9abf01d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
copilot:all
Type of Change